Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add key_revocation_action_field to google_compute_instance and related resources #19952

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Add key_revocation_action_field to google_compute_instance and related resources #19952

merged 1 commit into from
Oct 21, 2024

Conversation

modular-magician
Copy link
Collaborator

reopen of GoogleCloudPlatform/magic-modules#11741
Included all the change requests from the previous PR

  • Added the field to
    • google_compute_instance
    • google_compute_instance_from_template
    • google_compute_instance_from_machine_image
    • google_compute_instance_template
    • google_compute_region_instance_template
  • Added tests
  • Added data source support
  • Added doc changes

Release Note Template for Downstream PRs (will be copied)

compute: added `key_revocation_action_type` to `google_compute_instance` and related resources

Derived from GoogleCloudPlatform/magic-modules#11920

@modular-magician
Add key_revocation_action_field to google_compute_instance and re…
f5c2fd4 
…lated resources (hashicorp#11920)

Co-authored-by: Cameron Thornton <camthornton@google.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Co-authored-by: Nick Elliot <nickelliot@google.com>

[upstream:24a8c2f1cbc42d4d29703b9ad928019ad0119b79]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit d2503f7 into hashicorp:main Oct 21, 2024
4 checks passed
@hfsaito hfsaito mentioned this pull request Oct 29, 2024
Open
@modular-magician modular-magician deleted the downstream-pr-24a8c2f1cbc42d4d29703b9ad928019ad0119b79 branch November 16, 2024 23:32
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@modular-magician