Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: add support for kubelet read only port #19312

Conversation

modular-magician
Copy link
Collaborator

  • Add no_enable_insecure_kubelet_readonly_port to google_container_cluster
  • Allow setting insecure_kubelet_readonly_port_enabled for container_node_pool and friends

https://cloud.google.com/kubernetes-engine/docs/how-to/disable-kubelet-readonly-port

Fixes #15208

Note: @trodge: may be good to get some feedback internally from Google folks about what the right default behavior should be and if this will change over time. I'm trying to do this in the least breaking (for the provider) way, but from my very quick reading of the announcements, it's possible that default behavior may change in the future (and that this may depend on new vs. existing clusters and / or based on cluster version).

Release Note Template for Downstream PRs (will be copied)

container: added `insecure_kubelet_readonly_port_enabled` to `node_pool.node_config.kubelet_config` and `node_config.kubelet_config` in `google_container_node_pool` resource.
container: added `insecure_kubelet_readonly_port_enabled` to `node_pool_defaults.node_config_defaults`, `node_pool.node_config.kubelet_config`, and `node_config.kubelet_config` in `google_container_cluster` resource.

Derived from GoogleCloudPlatform/magic-modules#11272

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

[upstream:fcc529c34fcf793400595d5ad3df8924915a5976]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit fd33f35 into hashicorp:main Aug 28, 2024
2 checks passed
c2thorn pushed a commit that referenced this pull request Sep 5, 2024
[upstream:fcc529c34fcf793400595d5ad3df8924915a5976]

Signed-off-by: Modular Magician <magic-modules@google.com>
(cherry picked from commit fd33f35)
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2024
@modular-magician modular-magician deleted the downstream-pr-fcc529c34fcf793400595d5ad3df8924915a5976 branch November 17, 2024 01:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_container_cluster Disable the kubelet read-only port
1 participant