Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeletionProtectionEnabled to Redis Cluster #19173

Conversation

modular-magician
Copy link
Collaborator

Adding deletion protection enabled field in the Cluster resource in redis.

If this PR is for Terraform, I acknowledge that I have:

  1. Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it - Support Deletion Protection for Redis Cluster #17763

  2. Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).

  3. Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.

  4. Ran relevant acceptance tests using my own Google Cloud project and credentials.
    They show the following error -
    testing_new.go:85: Error running post-test destroy, there may be dangling resources: exit status 1 Error: Error waiting for Deleting Network: The network resource 'projects/harshig-test/global/networks/mynetworkpxlkaasq97' is already being used by 'projects/harshig-test/global/firewalls/mynetworkpxlkaasq97-vmvqhndc7vcvhkaszq37j4sh-4'4.

  5. Read/Write release notes before writing my release note below.

redis: added a `deletion_protection_enabled` field with a default value of `true` to the `google_redis_cluster` resource

Derived from GoogleCloudPlatform/magic-modules#10367

Co-authored-by: Nick Elliot <nickelliot@google.com>

[upstream:820e403355ea94ddbf666b9327231eb35bbfd5d8]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 0d58108 into hashicorp:FEATURE-BRANCH-major-release-6.0.0 Aug 16, 2024
3 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2024
@modular-magician modular-magician deleted the downstream-pr-820e403355ea94ddbf666b9327231eb35bbfd5d8 branch November 17, 2024 00:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant