Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retaining unchanged alias ip ranges and handle permadiff caused by the change #19015

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Add retaining unchanged alias ip ranges and handle permadiff caused by the change #19015

merged 1 commit into from
Aug 6, 2024

Conversation

modular-magician
Copy link
Collaborator

References issue #12286

  • added checkForCommonAliasIp() function and condition to use it
  • Added tests for this scenario
  • Maintaining the unchanged ranges causes permadiff because of sorting so flattening function needed to be rewritten

Release Note Template for Downstream PRs (will be copied)

compute: fixed maintaining unchanged `alias_ip_range` in `compute_instance` in between PATCH API calls and handled permadiff caused by the change

Derived from GoogleCloudPlatform/magic-modules#11321

@modular-magician
Add retaining unchanged alias ip ranges and handle permadiff caused b…
5732298 
…y the change (hashicorp#11321)

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

[upstream:8fbe154440c88dc24388746f2a1cd48929a293a3]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 541d33b into hashicorp:main Aug 6, 2024
2 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2024
@modular-magician modular-magician deleted the downstream-pr-8fbe154440c88dc24388746f2a1cd48929a293a3 branch November 17, 2024 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@modular-magician