Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VmwareengineExternalAddress and VmwareengineExternalAccessRule sweepers, refactor VmwareengineCluster sweeper to use shared function #18886

Conversation

modular-magician
Copy link
Collaborator

Fixes #18574

Lots of generated VMware Engine sweepers don't work, and this impacts contributions related to VMware Engine.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#11069

…` sweepers, refactor `VmwareengineCluster` sweeper to use shared function (hashicorp#11069)

[upstream:7cebdc23bf2ef00c6cebff13606a68516378ba8f]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit ba5b20b into hashicorp:main Jul 29, 2024
2 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
@modular-magician modular-magician deleted the downstream-pr-7cebdc23bf2ef00c6cebff13606a68516378ba8f branch November 16, 2024 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweeper VmwareengineExternalAddress doesn't work due to needing parental resource to create URLs
1 participant