Add DNS PTR record to Compute Instance

[nat-henderson]

Fixes #1333.

[nat-henderson]

Required a revendor - I'm going to run all the compute tests on this one.

[nat-henderson]

[TestAccComputeInstance_PTRRecord] [Test Output]
=== RUN   TestAccComputeInstance_PTRRecord
--- PASS: TestAccComputeInstance_PTRRecord (80.11s)
PASS

[rosbo]

Documentation?

[rosbo]

Do you need to set SetPublicPtr explicitely to true to turn it off if some was using public_ptr_domain_name and now removes it from their config?

[nat-henderson]

I don't really know why the API requires that SetPublicPtr be true and PublicPtrDomainName have the value, rather than just doing a null check on the latter, but the docs are clear about that. Creating the new AccessConfig means that it won't be set unless that's set in the current config - we do a full replace.

[rosbo]

We got bit a few times by that when in order to disable a feature in update, we had to use ForceSend false and nil values otherwise, the server would keep the value it currently had.

[nat-henderson]

Makes sense! I don't think it can happen here at all since we do a full replace. Let me add that to the test to be 100% sure.

[nat-henderson]

Test passes, even with imports, so it's definitely not a problem.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!