Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn against using emptyOrUnsetBlockDiffSuppress #12626

Conversation

modular-magician
Copy link
Collaborator

After GoogleCloudPlatform/magic-modules#6546 fixed some GKE problems, I dug into emptyOrUnsetBlockDiffSuppress a bit. I think we should recommend against using it- it's harder to understand, and is only used in two places so far.

I think what it really does is allow a user to specify an empty block when the API returns nil, which is pretty different than what O+C does. But it reads like an O+C replacement initially (and it somewhat is one). Also, I think it behaves weirdly with some values returned from the API.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Derived from GoogleCloudPlatform/magic-modules#6595

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit facec6c into hashicorp:main Sep 22, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2022
@modular-magician modular-magician deleted the downstream-pr-2a0e1bf7938f7dac441e3700220dfdf511cb42bc branch November 17, 2024 02:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant