Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "updated two defaults" #12551

Conversation

modular-magician
Copy link
Collaborator

Reverts GoogleCloudPlatform/magic-modules#6478

It seems the change in PR GoogleCloudPlatform/magic-modules#6478 causes a bunch of tests failed due to

 provider_test.go:315: Step 1/2 error: Error running apply: exit status 1
        
        Error: Error waiting to create Connector: Error waiting for Creating Connector: Error code 3, message: Operation failed: A Connector must specify either max_throughput or max_instances.
        
          with google_vpc_access_connector.connector,
          on terraform_plugin_test.tf line 2, in resource "google_vpc_access_connector" "connector":
           2: resource "google_vpc_access_connector" "connector" {

Derived from GoogleCloudPlatform/magic-modules#6541

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 53f6251 into hashicorp:main Sep 13, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2022
@modular-magician modular-magician deleted the downstream-pr-e57f11a95cb1b8b4730b94594b5fe95d7868173e branch November 17, 2024 01:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant