Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Add the ability to add Filestore instance backups via Terraform #7655

Closed
Shaybs opened this issue Oct 28, 2020 · 4 comments · Fixed by GoogleCloudPlatform/magic-modules#6742, terraform-google-modules/docs-examples#335, hashicorp/terraform-provider-google-beta#4963, #13209 or GoogleCloudPlatform/terraform-validator#1184
Closed

[Feature Request] Add the ability to add Filestore instance backups via Terraform #7655

Shaybs opened this issue Oct 28, 2020 · 4 comments · Fixed by GoogleCloudPlatform/magic-modules#6742, terraform-google-modules/docs-examples#335, hashicorp/terraform-provider-google-beta#4963, #13209 or GoogleCloudPlatform/terraform-validator#1184
Assignees
@googlerjk
Labels
enhancement new-resource size/m
Milestone
Goals

Comments

@Shaybs
Copy link

Shaybs commented Oct 28, 2020 •
edited
Loading

Feature request is in the title.
@ghost ghost added the enhancement label Oct 28, 2020
@upodroid
Copy link
Contributor

For reference: https://cloud.google.com/filestore/docs/reference/rest/v1beta1/projects.locations.backups

@rileykarson rileykarson added this to the Goals milestone Nov 2, 2020
@tianmarin
Copy link

tianmarin commented Jul 21, 2021 •
edited
Loading

Is there a way to call a gcloud commando to create backups while this feature is developed?

@upodroid
Copy link
Contributor

yeah.

gcloud filestore backups https://cloud.google.com/sdk/gcloud/reference/filestore/backups

Riley, this resource isn't really great for terraform given how it is intended to work. Something like a snapshot policy that you can attach to it to create backups on an interval(Something for Filestore Product Team to improve) would be more useful.

Also, fileshare.0.source_backups needs to be added to google_filestore_instance for completeness.

@googlerjk googlerjk mentioned this issue Nov 23, 2022
Merged
5 tasks
c2thorn pushed a commit to GoogleCloudPlatform/magic-modules that referenced this issue Dec 9, 2022
@googlerjk
Added backup support for google_filestore_instance (#6742)
2f6206c 
Co-authored-by: Cameron Thornton <camthornton@google.com>
fixes hashicorp/terraform-provider-google#7655
modular-magician added a commit to modular-magician/docs-examples that referenced this issue Dec 9, 2022
@modular-magician
Added backup support for google_filestore_instance (#6742)
ac8b501 
Co-authored-by: Cameron Thornton <camthornton@google.com>
fixes hashicorp/terraform-provider-google#7655

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician mentioned this issue Dec 9, 2022
Merged
5 tasks
modular-magician added a commit to terraform-google-modules/docs-examples that referenced this issue Dec 9, 2022
@modular-magician
Added backup support for google_filestore_instance (#6742) (#335)
68175d0 
Co-authored-by: Cameron Thornton <camthornton@google.com>
fixes hashicorp/terraform-provider-google#7655

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this issue Dec 9, 2022
@modular-magician
Added backup support for google_filestore_instance (hashicorp#6742)
c0db6e8 
Co-authored-by: Cameron Thornton <camthornton@google.com>
fixes hashicorp/terraform-provider-google#7655

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician mentioned this issue Dec 9, 2022
Merged
5 tasks
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Dec 9, 2022
@modular-magician
Added backup support for google_filestore_instance (hashicorp#6742)
25e2483 
Co-authored-by: Cameron Thornton <camthornton@google.com>
fixes hashicorp#7655

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician mentioned this issue Dec 9, 2022
Merged
5 tasks
modular-magician added a commit to hashicorp/terraform-provider-google-beta that referenced this issue Dec 9, 2022
@modular-magician
Added backup support for google_filestore_instance (#6742) (#4963)
3d3467d 
Co-authored-by: Cameron Thornton <camthornton@google.com>
fixes hashicorp/terraform-provider-google#7655

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Dec 9, 2022
@modular-magician
Added backup support for google_filestore_instance (#6742) (#13209)
50bb03d 
Co-authored-by: Cameron Thornton <camthornton@google.com>
fixes #7655

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to modular-magician/terraform-validator that referenced this issue Dec 9, 2022
@modular-magician
Added backup support for google_filestore_instance (#6742)
9cf5f79 
Co-authored-by: Cameron Thornton <camthornton@google.com>
fixes hashicorp/terraform-provider-google#7655

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician mentioned this issue Dec 9, 2022
Merged
5 tasks
modular-magician added a commit to GoogleCloudPlatform/terraform-validator that referenced this issue Dec 9, 2022
@modular-magician
Added backup support for google_filestore_instance (#6742) (#1184)
77767a7 
Co-authored-by: Cameron Thornton <camthornton@google.com>
fixes hashicorp/terraform-provider-google#7655

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
@googlerjk googlerjk self-assigned this Dec 9, 2022
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@googlerjk googlerjk

Labels
enhancement new-resource size/m
Projects
None yet
Milestone
Goals
5 participants
@rileykarson @tianmarin @upodroid @Shaybs @googlerjk