Feature Request: support rolling updates for google instance group manager.

[hashibot]

This issue was originally opened by @qvallance-ctc as hashicorp/terraform#10647. It was migrated here as part of the provider split. The original body of the issue is below.

---

Google has added functionality for performing rolling updates for managed instance groups.
https://cloud.google.com/compute/docs/instance-groups/updating-managed-instance-groups

Would like Terraform's google_compute_instance_group_manager to support rolling updates as an update policy.

(Functionality is currently in Alpha - opening request to track progress for when it goes GA)

InstanceGroupManagerUpdatePolicy (v0.alpha)
https://code.googlesource.com/google-api-go-client/+/master/compute/v0.alpha/compute-gen.go#7175
https://code.googlesource.com/google-api-go-client/+/master/compute/v0.alpha/compute-api.json#4339

[rileykarson]

Linking to the general alpha/beta issue: #93

[danielcompton]

One thing that could be useful to have (maybe in a separate PR, but thought I'd mention it here), is the ability to keep the last n instance group templates around. This would mean you could do things like canary deploys, or rollback to previous templates with the instance group updater.

[domdoescode]

Giving this a bump as it's now in beta (as instructed here) =)

[zbikmarc]

Any chances to have it done in near future?

[shaharmor]

I would be happy to see this as well

[amarlot]

Confirmed. It would be great to support rolling update.

[seanmalloy]

@danawillow this would be a very nice feature to have. I sent you brief email with some additional details.

[danawillow]

@paddycarver looks like this is assigned to you. Have you started thinking about this? Also @ishashchuk it looks like you might be doing some work around this. If you are could you claim the issue here so we don't end up duplicating work? Thanks!

[paddycarver]

I've investigated this and it's on my short list. I'll either have an update on 3/1 or will unassign myself from the issue at that time to free it up for someone else to nab. Sorry for the slowness on my end. :(

[ishashchuk]

@danawillow I already have something working for instance group manager and am planning to create a PR shortly. Once I get some feedback around my approach, my plan is to implement it for regional instance group manager in a separate request.

[amoiseiev]

@danawillow @paddycarver hey guys, we should have claimed this item earlier, it's on our high priority list, sorry for this. As @ishashchuk mentioned above, we're committed to get this implemented for main components of the rolling updates for IGMs and rIGMs. It won't include "canary updates" on its first iteration but should implement basic rolling updates that will cover, in our opinion, most use cases for general public. We're also ready to get any changes requested in the review process implemented in a timely manner, just need the reviews from your team :)

[paddycarver]

Cool! I'm going to unassign myself (sorry for the failure to communicate on my part!) just for clarity.

I'd be happy to review any PR you want to send our way, and am super grateful you're willing to take on the work and are open to feedback!

[paddycarver]

Oops, I just saw #1137, I'll review that ASAP. Very excited for this!

[paddycarver]

Looks like #1137 has been merged, thanks @ndmckinley! Closing this out.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!