Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IAP in google_app_engine_application resource #3065

Closed

Comments

@marcin-kolda
Copy link
Contributor

marcin-kolda commented Feb 15, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

We would like to configure IAP on GAE with Terraform. Full automation is blocked by #1287, but at least there will be less manual work and we will be able to control that IAP is not disabled.

New or Affected Resource(s)

  • google_app_engine_application

Potential Terraform Configuration

Terraform configuration for IAP on GAE could be similar as in google_compute_backend_service resource

resource "google_app_engine_application" "app" {
  project     = "${var.my_project_id}"
  location_id = "us-central"
  iap {
    oauth2_client_id = "my_client_id"
    oauth2_client_secret = "my_secret"
  }
}

References

@ghost ghost added the enhancement label Feb 15, 2019
@paddycarver paddycarver added this to the Near-Term Goals milestone Dec 11, 2019
@danawillow danawillow modified the milestones: Near-Term Goals, Sprint 6 Jan 27, 2020
@megan07 megan07 self-assigned this Jan 31, 2020
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Feb 3, 2020
…e retrieved secret data in secret_version datasource (hashicorp#3065)

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Feb 3, 2020
…e retrieved secret data in secret_version datasource (#3065) (#5570)

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.