Check for errors in google_project datasource Read results (#7036) (#…

…13358) Signed-off-by: Modular Magician <magic-modules@google.com> Signed-off-by: Modular Magician <magic-modules@google.com>
hashicorp · Dec 28, 2022 · f5c58e5 · f5c58e5
1 parent 2ad8dfe
commit f5c58e5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/.changelog/7036.txt b/.changelog/7036.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+resourcemanager: fixed the `google_project` datasource silently returning empty results when the project was not found or not in the ACTIVE state. Now, an error will be surfaced instead.
+```
diff --git a/google/data_source_google_project.go b/google/data_source_google_project.go
@@ -33,5 +33,15 @@ func datasourceGoogleProjectRead(d *schema.ResourceData, meta interface{}) error
 		d.SetId(fmt.Sprintf("projects/%s", project))
 	}
 
-	return resourceGoogleProjectRead(d, meta)
+	id := d.Id()
+
+	if err := resourceGoogleProjectRead(d, meta); err != nil {
+		return err
+	}
+
+	if d.Id() == "" {
+		return fmt.Errorf("%s not found or not in ACTIVE state", id)
+	}
+
+	return nil
 }