Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acceptance tests for how provider handles impersonate_service_account argument #8265

Conversation

modular-magician
Copy link
Collaborator

This PR adds acceptance tests for usage of impersonate_service_account that demonstrate:

  • how the provider behaves when provider configuration arguments come from different sources ( config vs ENVs)
    • There is only a single ENV used for this argument, versus other arguments
  • schema-level validation that's in place, e.g. handling of empty strings
  • use cases: how does this argument impact the providers behaviour in plan/apply

Note: this PR does not include testing usage of impersonate_service_account when using PF-implemented resource/data source as doing this in the context of Firebase (the only service with PF-implemented stuff) is very complex.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#11641

…count` argument (#11641)

[upstream:b6c3277a6d303977d199ca084f52e77b72004bcc]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit bb58732 into hashicorp:main Sep 24, 2024
2 checks passed
@modular-magician modular-magician deleted the downstream-pr-b6c3277a6d303977d199ca084f52e77b72004bcc branch November 16, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant