Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ga version of bigquery reservation #2813

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Add ga version of bigquery reservation #2813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/4342.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
bigquery: promoted bigquery reservation to GA.
```
9 changes: 7 additions & 2 deletions google-beta/resource_bigquery_reservation_reservation_generated_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func TestAccBigqueryReservationReservation_bigqueryReservationBasicExample(t *te

vcrTest(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProvidersOiCS,
Providers: testAccProviders,
ExternalProviders: map[string]resource.ExternalProvider{
"random": {},
},
Expand All @@ -41,14 +41,19 @@ func TestAccBigqueryReservationReservation_bigqueryReservationBasicExample(t *te
{
Config: testAccBigqueryReservationReservation_bigqueryReservationBasicExample(context),
},
{
ResourceName: "google_bigquery_reservation.reservation",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"location", "name"},
},
},
})
}

func testAccBigqueryReservationReservation_bigqueryReservationBasicExample(context map[string]interface{}) string {
return Nprintf(`
resource "google_bigquery_reservation" "reservation" {
provider = google-beta
name = "reservation%{random_suffix}"
location = "asia-northeast1"
// Set to 0 for testing purposes
Expand Down
3 changes: 0 additions & 3 deletions website/docs/r/bigquery_reservation.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ description: |-

A reservation is a mechanism used to guarantee BigQuery slots to users.

~> **Warning:** This resource is in beta, and should be used with the terraform-provider-google-beta provider.
See [Provider Versions](https://terraform.io/docs/providers/google/guides/provider_versions.html) for more details on beta resources.

To get more information about Reservation, see:

Expand All @@ -43,7 +41,6 @@ To get more information about Reservation, see:

```hcl
resource "google_bigquery_reservation" "reservation" {
provider = google-beta
name = "reservation"
location = "asia-northeast1"
// Set to 0 for testing purposes
Expand Down