Add acceptance test for TF_VAR environment variable usage #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detro
approved these changes
Apr 14, 2022
| @@ -109,6 +109,40 @@ func TestAccFrameworkResourceUser_interpolateLanguage(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| // Reference: https://github.com/hashicorp/terraform-plugin-sdk/issues/935 | |||
| func TestAccFrameworkResourceUser_TF_VAR_Environment_Variable(t *testing.T) { | |||
| expectedUserName := "Ford Prefect" | |||
There was a problem hiding this comment.
LOL - I see what you did there ;)
Reference: hashicorp/terraform-plugin-sdk#935 With github.com/hashicorp/terraform-plugin-sdk/v2@v2.13.0: ```console $ TF_ACC=1 go test -count=1 -run='TestAccFrameworkResourceUser_TF_VAR_Environment_Variable' -v ./internal/frameworkprovider/ === RUN TestAccFrameworkResourceUser_TF_VAR_Environment_Variable resource_user_test.go:117: Step 1/1 error: Error running pre-apply refresh: variable "framework_user_name" was required but not supplied --- FAIL: TestAccFrameworkResourceUser_TF_VAR_Environment_Variable (0.56s) FAIL FAIL github.com/hashicorp/terraform-provider-corner/internal/frameworkprovider 1.324s FAIL ``` Passes with hashicorp/terraform-plugin-sdk#937.
bflad
force-pushed
the
bflad-tfvar-usage
branch
from
df9f402 to
0592d86
Compare
|
Rebased after merging terraform-plugin-sdk update and all green, merging! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This new acceptance test will fail until github.com/hashicorp/terraform-plugin-sdk/v2@v2.14.0 is released and this project's Go module is updated. Will rebase once that's done.
Reference: hashicorp/terraform-plugin-sdk#935
With github.com/hashicorp/terraform-plugin-sdk/v2@v2.13.0:
Passes with hashicorp/terraform-plugin-sdk#937.