-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add LDAP auth-method, accounts and managed groups support #325
Conversation
9d5f555
to
dcdddde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run make docs
or go generate
locally to generate the docs for TF registry.
One comment about dropping a newly added resource and one minor test comment otherwise this looks really great!
dcdddde
to
206582a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
229786e
to
909a0ff
Compare
…ashicorp#325) * chore: point to boundary ldap bits * refactor (test): common auth method test funcs * chore (deps): add gldap for test ldap directory * feature: add LDAP auth-method, accounts and managed groups support
Do not merge until Boundary PR #2912 feature (auth/ldap has been merged and you've updated the boundary go.mod dependency back to main