Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add LDAP auth-method, accounts and managed groups support #325

Merged
merged 9 commits into from
Mar 15, 2023

Conversation

jimlambrt
Copy link
Contributor

Do not merge until Boundary PR #2912 feature (auth/ldap has been merged and you've updated the boundary go.mod dependency back to main

Copy link
Contributor

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run make docs or go generate locally to generate the docs for TF registry.
One comment about dropping a newly added resource and one minor test comment otherwise this looks really great!

@jimlambrt jimlambrt requested a review from louisruch February 15, 2023 20:59
@jimlambrt jimlambrt added this to the 0.14.0 milestone Feb 16, 2023
Copy link
Contributor

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimlambrt jimlambrt modified the milestones: 0.14.0, 0.13.x Mar 3, 2023
@jimlambrt jimlambrt force-pushed the jimlambrt-auth-ldap branch from 229786e to 909a0ff Compare March 15, 2023 17:17
@jimlambrt jimlambrt merged commit dcd10c1 into main Mar 15, 2023
@jimlambrt jimlambrt deleted the jimlambrt-auth-ldap branch March 15, 2023 18:30
grantorchard pushed a commit to grantorchard/terraform-provider-boundary that referenced this pull request Aug 28, 2023
…ashicorp#325)

* chore: point to boundary ldap bits

* refactor (test): common auth method test funcs

* chore (deps): add gldap for test ldap directory

* feature: add LDAP auth-method, accounts and managed groups support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants