Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force new resource on database collation update. #969

Closed

Conversation

ShepardToTheStars
Copy link
Contributor

@ShepardToTheStars ShepardToTheStars commented Mar 13, 2018

Bug fix for Issue #844.

  • Acceptance test coverage of new behavior. (See question below)
  • Documentation updates
  • Well-formed Code

Are acceptance tests needed for this change? (It doesn't look like the other SQL database resources are testing for this specific condition either)

@tombuildsstuff tombuildsstuff added bug service/mssql Microsoft SQL Server labels Mar 13, 2018
@ShepardToTheStars ShepardToTheStars changed the title [WIP] Force new resource on database collation update. Force new resource on database collation update. Mar 13, 2018
@tombuildsstuff tombuildsstuff added this to the 1.3.1 milestone Mar 14, 2018
@tombuildsstuff tombuildsstuff modified the milestones: 1.3.1, 1.3.2 Mar 29, 2018
@mbfrahry
Copy link
Member

mbfrahry commented Apr 3, 2018

Hey @vlouwagie, it's always good to write a quick test to confirm that it works as expected and just in case anything changes with the api or sdk. I've written one and can push it up to this branch if that's ok with you. Otherwise this looks good!

@ShepardToTheStars
Copy link
Contributor Author

@mbfrahry Sounds good to me. Thank you for doing that. 😄

@mbfrahry
Copy link
Member

mbfrahry commented Apr 3, 2018

Not a problem. I've submitted a new PR since I can't commit to this one. Your commits are saved in that branch so I'll close this in favor of #1066. Thanks again for this submission!

@mbfrahry mbfrahry closed this Apr 3, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug service/mssql Microsoft SQL Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants