Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ignore case function for diffs on the managed data disk ids. #792

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

jzampieron
Copy link
Contributor

This provides a way to work around #582 by using the Azure Portal
to attach disks.

This provides a way to work around hashicorp#582 by using the Azure Portal
to attach disks.
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jzampieron

Thanks for this PR - I've taken a look and this LGTM, so I'll kick off the test suite now 👍

Thanks!

@jzampieron
Copy link
Contributor Author

jzampieron commented Feb 6, 2018

Just as a follow up. I do have an open ticket with Azure support to discuss the expected behavior here.

At the very least the Azure documentation needs to reflect the case behavior of these REST values.

I expect any kind of official word or resolution to take several weeks.

@tombuildsstuff
Copy link
Contributor

Ignoring some temporary test failures in Azure - the tests LGTM:

screen shot 2018-02-06 at 11 12 26

@tombuildsstuff
Copy link
Contributor

Just as a follow up. I do have an open ticket with Azure support to discuss the expected behavior here.
At the very least the Azure documentation needs to reflect the case behavior of these REST values.

@jzampieron yeah, that sounds sensible - @metacpp should be able to raise the issue with the Portal team

@tombuildsstuff tombuildsstuff merged commit bfb6836 into hashicorp:master Feb 6, 2018
tombuildsstuff added a commit that referenced this pull request Feb 6, 2018
@tombuildsstuff
Copy link
Contributor

@jzampieron just to let you know that this has been released in v1.1.1 :)

@jzampieron jzampieron deleted the fix-582 branch February 7, 2018 15:43
@jzampieron
Copy link
Contributor Author

As an update. Azure support was able to reproduce the behavior and is discussing further with the Portal engineering team to understand if this is expected, desired, etc and generate appropriate follow-up actions.

I will track it here as I remember to.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants