azurerm_role_assignment - generating a name if one isn't specified
#685
Conversation
| @@ -7,6 +7,7 @@ import ( | |||
|
|
|||
| "github.com/Azure/azure-sdk-for-go/arm/authorization" | |||
| "github.com/hashicorp/terraform/helper/schema" | |||
| "github.com/satori/uuid" | |||
There was a problem hiding this comment.
Should we be using go-uuid here to stay in line with the rest of the HashiCorp ecosystem?
There was a problem hiding this comment.
possibly - the Azure SDK uses this version (and now github.com/marstr/guid) - so I picked it for internal consistency tbh; I'll update this
| @@ -56,6 +58,10 @@ func resourceArmRoleAssignmentCreate(d *schema.ResourceData, meta interface{}) e | |||
| roleDefinitionId := d.Get("role_definition_id").(string) | |||
| principalId := d.Get("principal_id").(string) | |||
|
|
|||
| if name == "" { | |||
| name = uuid.NewV1().String() | |||
There was a problem hiding this comment.
Minor-ish nit here, but we should be using v4 UUIDs to ensure they are as random as possible.
Tests pass: ``` $ acctests azurerm TestAccAzureRMRoleAssignment_emptyName === RUN TestAccAzureRMRoleAssignment_emptyName --- PASS: TestAccAzureRMRoleAssignment_emptyName (19.37s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 19.400 ```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Making the Name optional for a Role Assignment, and generating a name (UUID) if one isn't specified
Fixes #667