Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade azure-sdk-for-go to v38.1.0 and frontdoor to 2019-11-01 #5385

Merged
merged 5 commits into from
Jan 17, 2020
Merged

Upgrade azure-sdk-for-go to v38.1.0 and frontdoor to 2019-11-01 #5385

merged 5 commits into from
Jan 17, 2020

Conversation

timja
Copy link
Contributor

@timja timja commented Jan 13, 2020

@ghost ghost added the size/XS label Jan 13, 2020
@ghost ghost added dependencies size/XXL and removed size/XS labels Jan 13, 2020
@timja timja changed the title Upgrade azure-sdk-for-go to v38.1.0 Upgrade azure-sdk-for-go to v38.1.0 and frontdoor api version Jan 13, 2020
@tombuildsstuff tombuildsstuff added this to the v1.42.0 milestone Jan 13, 2020
@timja
Copy link
Contributor Author

timja commented Jan 14, 2020

Acceptance tests are failing, looking into it

@timja timja mentioned this pull request Jan 14, 2020
Closed
timja
timja commented Jan 14, 2020
View reviewed changes
azurerm/internal/services/frontdoor/tests/resource_arm_front_door_firewall_policy_test.go
@@ -272,7 +272,7 @@ resource "azurerm_frontdoor_firewall_policy" "test" {
}
}

%s
%[3]s
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test must have been failing before this PR, this was passing in the region text before, in my case "West Europe" was randomly being placed in the resource body

@timja timja mentioned this pull request Jan 15, 2020
Merged
@timja timja requested a review from WodansSon January 16, 2020 07:48
katbyte
katbyte approved these changes Jan 17, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @timja, LGTM 👍

@katbyte katbyte changed the title Upgrade azure-sdk-for-go to v38.1.0 and frontdoor api version Upgrade azure-sdk-for-go to v38.1.0 and frontdoor to 2019-11-01 Jan 17, 2020
@katbyte katbyte merged commit 6edad2b into hashicorp:master Jan 17, 2020
@timja timja deleted the upgrade-sdk branch January 17, 2020 14:22
katbyte added a commit that referenced this pull request Jan 17, 2020
@katbyte
Update CHANGELOG.md to include #5335 & #5385
d7bbb3a
@sean-nixon sean-nixon mentioned this pull request Jan 27, 2020
Closed
@ghost
Copy link

ghost commented Jan 27, 2020

This has been released in version 1.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.42.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@WodansSon WodansSon Awaiting requested review from WodansSon

Assignees

@WodansSon WodansSon

Labels
dependencies service/frontdoor size/XXL
Projects
None yet
Milestone
v1.42.0
Development

Successfully merging this pull request may close these issues.
4 participants
@timja @katbyte @tombuildsstuff @WodansSon