Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/kubernetes_cluster: switching back to parallel tests #5339

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

tombuildsstuff
Copy link
Contributor

Trialled switching back to regular (non-parallel'd) test cases to work around API performance issues, but this ultimately wasn't fruitful

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from one comment 👍

@@ -237,6 +237,28 @@ func resourceArmKubernetesCluster() *schema.Resource {
},
},

"service_principal": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll want to revert this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah this is just a minor regrouping from where the service_principal block went from required -> optional -> required in the last PR and I didn't want travis to block the release - so this should be fine 👍

@tombuildsstuff tombuildsstuff merged commit 76c191a into master Jan 9, 2020
@tombuildsstuff tombuildsstuff deleted the r/kubernetes-cluster branch January 9, 2020 05:28
@ghost
Copy link

ghost commented Jan 16, 2020

This has been released in version 1.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.41.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants