Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_cosmos_mongo_*: fix throughput & deprecate indexes #5116

Merged
merged 12 commits into from
Dec 11, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Dec 10, 2019

continuation of #4620

this also deprecated the indexes property as it seems to be ignored by the API now & shared_key has the same affect

@katbyte katbyte requested a review from a team December 10, 2019 20:01
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus some minor comments

azurerm/resource_arm_cosmosdb_mongo_collection.go Outdated Show resolved Hide resolved
website/docs/r/network_watcher.html.markdown Outdated Show resolved Hide resolved
@katbyte katbyte merged commit b711bd1 into master Dec 11, 2019
@katbyte katbyte deleted the cosmos/mongo_throughput branch December 11, 2019 01:17
katbyte added a commit that referenced this pull request Dec 11, 2019
@ghost
Copy link

ghost commented Dec 16, 2019

This has been released in version 1.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.39.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants