`azurerm_key_vault_secret` - support for `not_before_date` and `expiration_date` #4873

aqche · 2019-11-14T02:30:16Z

Adds the not_before_date and expiration_date options to the azurerm_key_vault_secret resource.

--- PASS: TestAccAzureRMKeyVaultSecret_complete (219.48s)
--- PASS: TestAccAzureRMKeyVaultSecret_disappearsWhenParentKeyVaultDeleted (224.89s)
--- PASS: TestAccAzureRMKeyVaultSecret_basic (235.53s)
--- PASS: TestAccAzureRMKeyVaultSecret_update (238.80s)
--- PASS: TestAccAzureRMKeyVaultSecret_disappears (244.47s)
--- PASS: TestAccAzureRMKeyVaultSecret_basicClassic (247.29s)

mbfrahry

Hey @aqche, this PR is nearly there. We just need to do a nil check and remove a duplicated line and we should be good

mbfrahry · 2019-11-18T17:35:50Z

azurerm/resource_arm_key_vault_secret.go

@@ -280,6 +334,14 @@ func resourceArmKeyVaultSecretRead(d *schema.ResourceData, meta interface{}) err
 	d.Set("version", respID.Version)
 	d.Set("content_type", resp.ContentType)

+	if v := resp.Attributes.NotBefore; v != nil {


Attributes has the potential to be nil so we should that it isn't nil before referencing NotBefore and Expires

good call, added a nil check for Attributes

mbfrahry · 2019-11-18T17:36:40Z

azurerm/resource_arm_key_vault_secret_test.go

@@ -153,6 +153,9 @@ func TestAccAzureRMKeyVaultSecret_complete(t *testing.T) {
 				Config: config,
 				Check: resource.ComposeTestCheckFunc(
 					testCheckAzureRMKeyVaultSecretExists(resourceName),
+					resource.TestCheckResourceAttr(resourceName, "not_before_date", "2019-01-01T01:02:03Z"),
+					resource.TestCheckResourceAttr(resourceName, "expiration_date", "2020-01-01T01:02:03Z"),
+					resource.TestCheckResourceAttr(resourceName, "tags.hello", "world"),


The same check is done just a couple lines below. Can we remove this one?

whoops, removed!

aqche · 2019-11-18T23:19:45Z

@mbfrahry thanks for the review! addressed the comments. please take a look again when you have the chance.

mbfrahry

Perfect! Thanks for addressing that

katbyte · 2019-11-19T00:30:29Z

azurerm/resource_arm_key_vault_secret.go

+		notBeforeDate, err := time.Parse(time.RFC3339, v.(string))
+		if err != nil {
+			return fmt.Errorf("error parsing `not_before_date` time: %s", err)
+		}


technically we don't need to check for an error here because the validation function should catch all non valid time strings

makes sense, removed 👍

katbyte · 2019-11-19T00:30:35Z

azurerm/resource_arm_key_vault_secret.go

+		expirationDate, err := time.Parse(time.RFC3339, v.(string))
+		if err != nil {
+			return fmt.Errorf("error parsing `expiration_date` time: %s", err)
+		}


TestAccAzureRMPostgreSQLDatabase_collationWithHyphen

katbyte · 2019-11-19T00:30:40Z

azurerm/resource_arm_key_vault_secret.go

+		notBeforeDate, err := time.Parse(time.RFC3339, v.(string))
+		if err != nil {
+			return fmt.Errorf("error parsing `not_before_date` time: %s", err)
+		}


TestAccAzureRMPostgreSQLDatabase_collationWithHyphen

katbyte · 2019-11-19T00:30:48Z

azurerm/resource_arm_key_vault_secret.go

+		expirationDate, err := time.Parse(time.RFC3339, v.(string))
+		if err != nil {
+			return fmt.Errorf("error parsing `expiration_date` time: %s", err)
+		}


TestAccAzureRMPostgreSQLDatabase_collationWithHyphen

aqche · 2019-11-19T01:52:06Z

@katbyte updated per your suggestion, let me know what you think!

mbfrahry · 2019-11-19T02:43:41Z

Perfect! Thanks for getting this written. We'll get that out in the next release

ghost · 2019-11-26T08:34:52Z

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

ghost · 2019-12-19T14:50:18Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

add not_before_date and expiration_date to azurerm_key_vault_secret

ff13264

ghost added size/M documentation labels Nov 14, 2019

aqche mentioned this pull request Nov 14, 2019

Support for set and get activation and expiration date on azurerm_key_vault_secret #4858

Closed

mbfrahry requested changes Nov 18, 2019

View reviewed changes

add nil check for attributes, remove duplicate assert

01c011f

mbfrahry approved these changes Nov 19, 2019

View reviewed changes

katbyte reviewed Nov 19, 2019

View reviewed changes

katbyte added enhancement service/key-vault Key Vault labels Nov 19, 2019

katbyte added this to the v1.37.0 milestone Nov 19, 2019

remove uneeded err checks for parsing time

dbba161

mbfrahry changed the title ~~Add not_before_date and expiration_date args to azurerm_key_vault_secret~~ azurerm_key_vault_secret - support for not_before_date and expiration_date Nov 19, 2019

mbfrahry merged commit 784e232 into hashicorp:master Nov 19, 2019

mbfrahry added a commit that referenced this pull request Nov 19, 2019

Update changelog for #4873

726c54c

aqche deleted the azurerm_key_vault_secret_date_options branch December 5, 2019 05:42

ghost locked and limited conversation to collaborators Dec 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_key_vault_secret` - support for `not_before_date` and `expiration_date` #4873

`azurerm_key_vault_secret` - support for `not_before_date` and `expiration_date` #4873

aqche commented Nov 14, 2019 •

edited

Loading

mbfrahry left a comment

mbfrahry Nov 18, 2019

aqche Nov 18, 2019

mbfrahry Nov 18, 2019

aqche Nov 18, 2019

aqche commented Nov 18, 2019

mbfrahry left a comment

katbyte Nov 19, 2019

aqche Nov 19, 2019

katbyte Nov 19, 2019

katbyte Nov 19, 2019

katbyte Nov 19, 2019

aqche commented Nov 19, 2019

mbfrahry commented Nov 19, 2019

ghost commented Nov 26, 2019

ghost commented Dec 19, 2019

azurerm_key_vault_secret - support for not_before_date and expiration_date #4873

azurerm_key_vault_secret - support for not_before_date and expiration_date #4873

Conversation

aqche commented Nov 14, 2019 • edited Loading

mbfrahry left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aqche commented Nov 18, 2019

mbfrahry left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aqche commented Nov 19, 2019

mbfrahry commented Nov 19, 2019

ghost commented Nov 26, 2019

ghost commented Dec 19, 2019

`azurerm_key_vault_secret` - support for `not_before_date` and `expiration_date` #4873

`azurerm_key_vault_secret` - support for `not_before_date` and `expiration_date` #4873

aqche commented Nov 14, 2019 •

edited

Loading