azurerm_devspace_controller Bump API version

[nexxai]

Fixing after rebasing/reforking

[nexxai]

Fixes #3805

[katbyte]

Thanks for the pr @nexxai,

however i believe we'll need to update to a newer version yet:

Error: Error creating DevSpace Controller "acctestdsc190910092438094212" (Resource Group "acctestRG-190910092438094212"): devspaces.ControllersClient#Create: Failure sending request: StatusCode=400 -- Original Error: Code="NoRegisteredProviderFound" Message="No registered resource provider found for location 'westeurope' and API version '2019-01-01-preview' for type 'controllers'. The supported api-versions are '2019-04-01'. The supported locations are 'eastus, canadaeast, westeurope, canadacentral, centralus, westus2, westcentralus, southeastasia, eastus2, northeurope, australiaeast, uksouth, southcentralus'."

[nexxai]

@katbyte Sorry, I didn't even clue into the fact that I was still on the preview branch. Upgraded to 2019-04-01 (full public).

[katbyte]

Looks like there is a problem with the latest API version too:

testing.go:568: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        DESTROY/CREATE: azurerm_devspace_controller.test
          data_plane_fqdn:                          "azds-d4a0111e-cb75-45e2-9b14-424a2874f154.weu.azds.io" => "<computed>"
          host_suffix:                              "rwxnnlkqxm.weu.azds.io" => "suffix" (forces new resource)

😞

[tombuildsstuff]

👋

Taking a quick look here - unfortunately I can't immediately find the API documentation for DevSpace, but I'm wondering if the host_suffix field has become Computed in this latest API version, rather than being user-specifiable?

[katbyte]

Opened Azure/azure-sdk-for-go#5990 on the SDK to get more context into the issue

[tombuildsstuff]

hey @nexxai

Taking a closer look into this it appears the host_suffix field is now configured by Azure rather than being user-configurable - as such we need to update the API version being used we need to make this field Computed (meaning we'll read the value from whatever Azure tells us) rather than user-configurable.

Since fixing this is required to update the Azure SDK (which is a dependency for some other things we're working on) and this PR has conflicts (and for some reason doesn't show the origin repo/branch) - whilst I'd like to thank you for this contribution so that we can get this merged I'm going to close this PR in favour of a new one which updates the API version and makes this field user configurable - I hope you don't mind!

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!