Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_kusto_cluster #4129

Merged
merged 23 commits into from
Aug 29, 2019

Conversation

r0bnet
Copy link
Contributor

@r0bnet r0bnet commented Aug 21, 2019

This is the first resource for this issue:
#3856

I omitted the external_trusted_tenants because they made some trouble and i'm not sure for what they're needed. If anyone needs them feel free to contact me or create an issue and link me.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @r0bnet,

Overall this looks great, however i do wonder about combining sku tier and name like that. What is your reasoning there?

azurerm/resource_arm_kusto_cluster.go Show resolved Hide resolved
azurerm/resource_arm_kusto_cluster.go Show resolved Hide resolved
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @r0bnet

Thanks for this PR - taking a look through this mostly LGTM - if we can fix up the remaining issues this otherwise looks good 👍

Thanks!

azurerm/resource_arm_kusto_cluster.go Outdated Show resolved Hide resolved
azurerm/resource_arm_kusto_cluster.go Outdated Show resolved Hide resolved
azurerm/resource_arm_kusto_cluster.go Outdated Show resolved Hide resolved
azurerm/resource_arm_kusto_cluster.go Outdated Show resolved Hide resolved
azurerm/resource_arm_kusto_cluster.go Outdated Show resolved Hide resolved
azurerm/resource_arm_kusto_cluster.go Outdated Show resolved Hide resolved
azurerm/resource_arm_kusto_cluster.go Outdated Show resolved Hide resolved
azurerm/resource_arm_kusto_cluster.go Outdated Show resolved Hide resolved
website/docs/r/kusto_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/kusto_cluster.html.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @r0bnet

Thanks for pushing those changes - taking a look through this now LGTM 👍

Thanks!

@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review August 29, 2019 13:43

dismissing since changes have been pushed

@tombuildsstuff tombuildsstuff added this to the v1.34.0 milestone Aug 29, 2019
@tombuildsstuff
Copy link
Contributor

Ignoring a failing test for tags (fixed in 7f3bc78) the tests otherwise pass:

Screenshot 2019-08-29 at 15 35 43

Thanks for this @r0bnet 👍

@tombuildsstuff tombuildsstuff merged commit 98d2a26 into hashicorp:master Aug 29, 2019
tombuildsstuff added a commit that referenced this pull request Aug 29, 2019
@r0bnet r0bnet deleted the resource-azurerm_kusto_cluster branch August 30, 2019 04:55
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 29, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants