Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtual network support in API management service #3583

Closed
wants to merge 14 commits into from
Closed

Conversation

metacpp
Copy link
Contributor

@metacpp metacpp commented Jun 3, 2019

This PR introduces the Virtual Network support in API management service, this is required feature while adding API gateway in front of AKS cluster.

@ghost ghost added the size/L label Jun 3, 2019
@ghost ghost added size/M and removed size/L labels Jun 3, 2019
@tombuildsstuff
Copy link
Contributor

tombuildsstuff commented Jun 4, 2019

@metacpp thanks for this PR.

As far as I'm aware the API Management API version 2018-01-01 is broken with regard to Virtual Networks (we've raised a Swagger issue about this) - we've attempted to upgrade to 2019-01-01 which contains a fix for this but is then blocked on this PR: Azure/azure-rest-api-specs#6065 (comment) - are you seeing a different behaviour here?

Thanks!

@metacpp
Copy link
Contributor Author

metacpp commented Jun 4, 2019

@tombuildsstuff yes, create API management with virtual network is working well in 2018-01-01.

There's one issue with delete API: it's synchronous but should be asynchronous. This misleads Terraform that API management is deleted when API returns successfully, and it blocks the subnet from deletion by Terraform.

This was fixed in 2019-01-01, we need to upgrade to that version to resolve the deletion issue.

@metacpp metacpp marked this pull request as ready for review June 4, 2019 22:46
@ghost ghost added size/XXL dependencies and removed size/L labels Jun 5, 2019
@tombuildsstuff
Copy link
Contributor

@metacpp in which case this is blocked on Azure/azure-rest-api-specs#6065 (comment) (which is blocking the SDK upgrade #3446) which is blocking the original PR adding support for Virtual Networks in API Management: #2582 - so until the upstream Swagger issue is resolved I'm going to close this PR for the moment.

Thanks!

@ghost
Copy link

ghost commented Jul 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 6, 2019
@ghost ghost removed the waiting-response label Jul 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants