-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cosmos db/keyspace/table resources #3442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good other than the website documentation missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @katbyte
Thanks for this PR - taking a look through this mostly LGTM, if we can fix up the minor comments this should otherwise be good to merge 👍
Thanks!
page_title: "Azure Resource Manager: azurerm_cosmos_mongo_database" | ||
sidebar_current: "docs-azurerm-resource-cosmos-mongo-database" | ||
description: |- | ||
Manages a Cosmos Mongo Database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manages a Cosmos Mongo Database. | |
Manages a Mongo Database within a Cosmos DB Account. |
|
||
# azurerm_cosmos_sql_database | ||
|
||
Manages a Cosmos SQL Database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manages a Cosmos SQL Database. | |
Manages a SQL Database within a Cosmos DB Account. |
|
||
# azurerm_cosmos_table | ||
|
||
Manages a Cosmos Table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manages a Cosmos Table. | |
Manages a Table within a Cosmos DB Account. |
azurerm/provider.go
Outdated
"azurerm_cosmos_cassandra_keyspace": resourceArmCosmosCassandraKeyspace(), | ||
"azurerm_cosmos_mongo_database": resourceArmCosmosMongoDatabase(), | ||
"azurerm_cosmos_sql_database": resourceArmCosmosSQLDatabase(), | ||
"azurerm_cosmos_table": resourceArmCosmosTable(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make all of these:
"azurerm_cosmos_table": resourceArmCosmosTable(), | |
"azurerm_cosmosdb_table": resourceArmCosmosTable(), |
This is great stuff! Just what we need for what we're building at the moment 🥇 Can we please have a release soon? Pretty please? @tombuildsstuff |
This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.28.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
fixes #1671