Application Gateway: Moved validations from flatten to expand

[mcharriere]

Fixes #3338

[katbyte]

Thanks for doing this @mcharriere! beat me to it 🙂

looks like you have a test failure:

------- Stdout: -------
=== RUN   TestAccAzureRMApplicationGateway_routingRedirect_pathBased
=== PAUSE TestAccAzureRMApplicationGateway_routingRedirect_pathBased
=== CONT  TestAccAzureRMApplicationGateway_routingRedirect_pathBased
--- FAIL: TestAccAzureRMApplicationGateway_routingRedirect_pathBased (143.52s)
    testing.go:568: Step 0 error: errors during apply:
        
        Error: Error Creating/Updating Application Gateway "acctestag-190430164908300494" (Resource Group "acctestRG-190430164908300494"): network.ApplicationGatewaysClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="ApplicationGatewayRedirectConfigurationIncludePathCannotBeSpecifiedWithTargetUrl" Message="IncludePath cannot be specified along with TargetUrl for RedirectConfiguration /subscriptions/8708baf2-0a54-4bb4-905b-78d21ac150da/resourceGroups/acctestRG-190430164908300494/providers/Microsoft.Network/applicationGateways/acctestag-190430164908300494/redirectConfigurations/acctest-vnet-190430164908300494-PathRedirect." Details=[]
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test291406144/main.tf line 48:
          (source code not available)
        
        
FAIL

[mcharriere]

Thanks for doing this @mcharriere! beat me to it slightly_smiling_face

looks like you have a test failure:

------- Stdout: -------
=== RUN   TestAccAzureRMApplicationGateway_routingRedirect_pathBased
=== PAUSE TestAccAzureRMApplicationGateway_routingRedirect_pathBased
=== CONT  TestAccAzureRMApplicationGateway_routingRedirect_pathBased
--- FAIL: TestAccAzureRMApplicationGateway_routingRedirect_pathBased (143.52s)
    testing.go:568: Step 0 error: errors during apply:
        
        Error: Error Creating/Updating Application Gateway "acctestag-190430164908300494" (Resource Group "acctestRG-190430164908300494"): network.ApplicationGatewaysClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="ApplicationGatewayRedirectConfigurationIncludePathCannotBeSpecifiedWithTargetUrl" Message="IncludePath cannot be specified along with TargetUrl for RedirectConfiguration /subscriptions/8708baf2-0a54-4bb4-905b-78d21ac150da/resourceGroups/acctestRG-190430164908300494/providers/Microsoft.Network/applicationGateways/acctestag-190430164908300494/redirectConfigurations/acctest-vnet-190430164908300494-PathRedirect." Details=[]
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test291406144/main.tf line 48:
          (source code not available)
        
        
FAIL

Sorry I missed that. I've sent a commit fixing it.

[mcharriere]

Hi @katbyte, have you had the chance to take a look at this?
I'm about to send another PR and having this merged would be great. Thanks! 😄

[katbyte]

Just getting to it now @mcharriere 🙂 sorry it took a little longer to review, we were busy with build this week.

LGTM and all the tests pass! so 🚀

[ghost]

This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.28.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!