-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_data_factory_dataset_sql_server_table
#3236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @mbfrahry, aside from a few comments i've left inline this LGTM 👍
return &annotations | ||
} | ||
|
||
func flattenDataFactoryAnnotations(input *[]interface{}) []string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could use utils.FlattenStringArray
instead of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weirdly enough, I think it'd be a call to utils.ExpandStringArray
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought. I think it's needed because it's an *[]interface{} and we'd need to do some finagling to get it to a []string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh yea sorry, its so close to the signature, and as much as i'd want to ask if terraform would accept the interface array i know we should check they are all strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries!
azurerm/resource_arm_data_factory_dataset_sql_server_table_test.go
Outdated
Show resolved
Hide resolved
azurerm/resource_arm_data_factory_dataset_sql_server_table_test.go
Outdated
Show resolved
Hide resolved
azurerm/resource_arm_data_factory_dataset_sql_server_table_test.go
Outdated
Show resolved
Hide resolved
azurerm/resource_arm_data_factory_dataset_sql_server_table_test.go
Outdated
Show resolved
Hide resolved
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
This PR adds
azurerm_data_factory_dataset_sql_server_table
to the Data Factory collection and starts to consolidate some of the methods used between the resources into a single source underdatafactory.go