-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_service_plan
- Adding isolated memory intensive SKUs for azurerm_app_service_environment_v3
#28316
Open
adrianfuro
wants to merge
12
commits into
hashicorp:main
Choose a base branch
from
adrianfuro:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+80
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
documentation
service/app-service
size/XS
bug
and removed
enhancement
labels
Dec 17, 2024
adrianfuro
changed the title
ENHANCEMENT: Adding memory intensive SKUs for
[enhancement]: Dec 17, 2024
azurerm_service_plan
resourceazurerm_service_plan
- Adding memory intensive SKUs that are available on Portal
adrianfuro
changed the title
[enhancement]:
[enhancement]: Dec 17, 2024
azurerm_service_plan
- Adding memory intensive SKUs that are available on Portal azurerm_service_plan
- Adding memory intensive SKUs for azurerm_app_service_environment_v3
adrianfuro
changed the title
[enhancement]:
[enhancement]: Dec 17, 2024
azurerm_service_plan
- Adding memory intensive SKUs for azurerm_app_service_environment_v3
azurerm_service_plan
- Adding isolated memory intensive SKUs for azurerm_app_service_environment_v3
adrianfuro
changed the title
[enhancement]:
Dec 24, 2024
azurerm_service_plan
- Adding isolated memory intensive SKUs for azurerm_app_service_environment_v3
azurerm_service_plan
- Adding isolated memory intensive SKUs for azurerm_app_service_environment_v3
I've added necessary tests for the enhancement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
This PR will add
"I1mv2", "I2mv2", "I3mv2", "I4mv2", "I5mv2"
SKU's as available options forazurerm_service_plan
resource. These SKUs are available in Portal and API but not on Terraform since they were added in 2024 as supported SKUs officially.PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_service_plan
- adding memory intensive SKU's that are only available through API and Azure PortalThis is a (please select all that apply):
Related Issue(s)
Fixes #26853
Note
If this PR changes meaningfully during the course of review please update the title and description as required.