-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #25973 - add support for azurerm_application_gateway
Basic SKU (Preview)
#27440
base: main
Are you sure you want to change the base?
Closes #25973 - add support for azurerm_application_gateway
Basic SKU (Preview)
#27440
Conversation
… SKU supported features
azurerm_application_gateway
Basic SKU (Preview)azurerm_application_gateway
Basic SKU (Preview)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like all the tests are failing with:
------- Stdout: -------
=== RUN TestAccApplicationGateway_authCertificate
=== PAUSE TestAccApplicationGateway_authCertificate
=== CONT TestAccApplicationGateway_authCertificate
testcase.go:173: Step 1/6 error: Error running apply: exit status 1
Error: creating Application Gateway (Subscription: "*******"
Resource Group Name: "acctestRG-240920034903751201"
Application Gateway Name: "acctestag-240920034903751201"): performing CreateOrUpdate: unexpected status 400 (400 Bad Request) with error: AppGatewayV1SkuDeprecated: Application Gateway SKU tier Standard has been deprecated. Supported SKU tiers are Standard_v2,WAF_v2. Refer https://aka.ms/V1retirement.
with azurerm_application_gateway.test,
on terraform_plugin_test.tf line 72, in resource "azurerm_application_gateway" "test":
72: resource "azurerm_application_gateway" "test" {
--- FAIL: TestAccApplicationGateway_authCertificate (181.02s)
FAIL
As per https://learn.microsoft.com/en-us/azure/application-gateway/v1-retirement#retirement-timelines it looks like we can no longer deploy V1 SKUs of the application gateway since the 1st Sept. At the very least we need to remove any acceptance tests that use any V1 SKUs e.g I believe that this is out of the scope of this PR, so we should raise another to remove this capability. I don't think this is too much effort. @katbyte shall another issue be raised for the removal of these deprecated SKUs? |
@tedsmitt - could you swap the test SKUs to one that will allow them to pass? it's required to be able to test your changes properly for merge |
@katbyte I've updated the Acceptance Tests to use the V2 SKU, these should now pass. |
Community Note
Description
PR Checklist
Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_application_gateway
- support for theBasic
SKU tierThis is a (please select all that apply):
Related Issue(s)
Fixes #25973