Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dotnet_framework_version 8.0 for logic_app_standard resource #26983

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Support dotnet_framework_version 8.0 for logic_app_standard resource #26983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/services/logic/logic_app_standard_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,7 @@ func schemaLogicAppStandardSiteConfig() *pluginsdk.Schema {
"v4.0",
"v5.0",
"v6.0",
"v8.0",
}, false),
},

Expand Down
16 changes: 16 additions & 0 deletions internal/services/logic/logic_app_standard_resource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,6 +851,22 @@ func TestAccLogicAppStandard_dotnetVersion6(t *testing.T) {
})
}

func TestAccLogicAppStandard_dotnetVersion8(t *testing.T) {
data := acceptance.BuildTestData(t, "azurerm_logic_app_standard", "test")
r := LogicAppStandardResource{}

data.ResourceTest(t, r, []acceptance.TestStep{
{
Config: r.dotnetVersion(data, "~4", "v8.0"),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
check.That(data.ResourceName).Key("site_config.0.dotnet_framework_version").HasValue("v8.0"),
),
},
data.ImportStep(),
})
}

func TestAccLogicAppStandard_vNetIntegration(t *testing.T) {
data := acceptance.BuildTestData(t, "azurerm_logic_app_standard", "test")
r := LogicAppStandardResource{}
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/logic_app_standard.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ The `site_config` block supports the following:

* `cors` - (Optional) A `cors` block as defined below.

* `dotnet_framework_version` - (Optional) The version of the .NET framework's CLR used in this Logic App Possible values are `v4.0` (including .NET Core 2.1 and 3.1), `v5.0` and `v6.0`. [For more information on which .NET Framework version to use based on the runtime version you're targeting - please see this table](https://docs.microsoft.com/azure/azure-functions/functions-dotnet-class-library#supported-versions). Defaults to `v4.0`.
* `dotnet_framework_version` - (Optional) The version of the .NET framework's CLR used in this Logic App Possible values are `v4.0` (including .NET Core 2.1 and 3.1), `v5.0`, `v6.0` and `v8.0`. [For more information on which .NET Framework version to use based on the runtime version you're targeting - please see this table](https://docs.microsoft.com/azure/azure-functions/functions-dotnet-class-library#supported-versions). Defaults to `v4.0`.

* `elastic_instance_minimum` - (Optional) The number of minimum instances for this Logic App Only affects apps on the Premium plan.

Expand Down
Loading