Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_log_analytics_cluster - add 100 as valid size_gb #26865

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

stephybun
Copy link
Member

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Also changes the default value for size_gb to 100 in 4.0

Testing

These tests are skipped in TC because of the high cost when deletion goes wrong. The basic test was run locally with size_gb = 100.

Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun left one query on the docs but otherwise LGTM!

website/docs/r/log_analytics_cluster.html.markdown Outdated Show resolved Hide resolved
@stephybun stephybun merged commit 7a47853 into main Jul 31, 2024
33 checks passed
@stephybun stephybun deleted the f/support-100-sku-la-cluster branch July 31, 2024 10:12
@github-actions github-actions bot added this to the v3.114.0 milestone Jul 31, 2024
stephybun added a commit that referenced this pull request Aug 1, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants