azurerm_linux_web_app - support 8.3 for the php_version property

[Chambras]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Adding support for PHP 8.3 in Linux Web Apps and Linux WebApp Slot.
Updated documentation with new version support.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Linux WebApp test log:

$ make acctests SERVICE='appservice' TESTARGS=' -run=TestAccLinuxWebApp_withPhp83' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccLinuxWebApp_withPhp83 -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccLinuxWebApp_withPhp83
=== PAUSE TestAccLinuxWebApp_withPhp83
=== CONT  TestAccLinuxWebApp_withPhp83
--- PASS: TestAccLinuxWebApp_withPhp83 (138.99s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice    139.010s

Linuz WebApp Slot test log:

$ make acctests SERVICE='appservice' TESTARGS=' -run=TestAccLinuxWebAppSlot_withPhp83' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccLinuxWebAppSlot_withPhp83 -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccLinuxWebAppSlot_withPhp83
=== PAUSE TestAccLinuxWebAppSlot_withPhp83
=== CONT  TestAccLinuxWebAppSlot_withPhp83
--- PASS: TestAccLinuxWebAppSlot_withPhp83 (223.50s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice    223.519s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_linux_web_app - support for PHP 8.3
• azurerm_linux_web_app_slot - support for PHP 8.3

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #26121

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

Thanks for this PR @Chambras. Overall this looks fine, just the additional settings in the test templates are problematic, we shouldn't be changing test configs and setting additional properties that are unrelated to the change at hand. Could you please provide some context here?

[Chambras]

Thanks for the feedback @stephybun removed the extra properties in the template and all checks passed :)

[katbyte]

LGTM 🌩️

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.