Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Management Groups in azurerm_policy_set_definition #2618

Conversation

olohmann
Copy link
Contributor

@olohmann olohmann commented Jan 8, 2019

This PR adds support for a Management Groups in Azure Policy Set Definitions (resource azurerm_policy_set_definition).

Addresses issue #2617.

Test Results:

> $ make testacc TESTARGS='-run=TestAccAzureRMPolicySetDefinition'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccAzureRMPolicySetDefinition -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
?   	github.com/terraform-providers/terraform-provider-azurerm	[no test files]
=== RUN   TestAccAzureRMPolicySetDefinition_builtIn
=== PAUSE TestAccAzureRMPolicySetDefinition_builtIn
=== RUN   TestAccAzureRMPolicySetDefinition_custom
=== PAUSE TestAccAzureRMPolicySetDefinition_custom
=== RUN   TestAccAzureRMPolicySetDefinition_ManagementGroup
=== PAUSE TestAccAzureRMPolicySetDefinition_ManagementGroup
=== CONT  TestAccAzureRMPolicySetDefinition_builtIn
=== CONT  TestAccAzureRMPolicySetDefinition_ManagementGroup
=== CONT  TestAccAzureRMPolicySetDefinition_custom
--- PASS: TestAccAzureRMPolicySetDefinition_builtIn (110.35s)
--- PASS: TestAccAzureRMPolicySetDefinition_ManagementGroup (149.36s)
--- PASS: TestAccAzureRMPolicySetDefinition_custom (202.85s)

(fixed #2617)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the enhancement resource @olohmann! This LGTM 🙂

@katbyte katbyte merged commit 657c776 into hashicorp:master Jan 9, 2019
@katbyte katbyte added this to the 1.21.0 milestone Jan 9, 2019
katbyte added a commit that referenced this pull request Jan 9, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Management Groups in azurerm_policy_set_definition
2 participants