Added Speech Services Kind #2583
Conversation
When trying to provision a resource of `Speech` kind, there are errors. To correct for this, I added kind `SpeechServices` which should be compatible with the kind being used by Azure currently for that resource.
There was a problem hiding this comment.
Hi @lqdev,
Thank you for this addition. Looking at the resource & SDK its clear it needs to be updated to use the SDK enum values as I don't see Speech, but then I also don't see SpeechServices. Is this a new addition to the service? because the possible values the SDK recognizes are:
// BingSpeech ...
BingSpeech Kind = "Bing.Speech"
// CustomSpeech ...
CustomSpeech Kind = "CustomSpeech"
// SpeakerRecognition ...
SpeakerRecognition Kind = "SpeakerRecognition"
// SpeechTranslation ...
SpeechTranslation Kind = "SpeechTranslation"The documentation will require updating with any new values.
|
Hi, I've hit this problem before and raised an issue see -> #2294 which covers the origin of the missing kind. Neil |
|
Thanks @katbyte and @neilbailie for providing more clarification. At the time of this addition I looked at the output form Azure CLI for the kind of service I wanted to deploy. I was under the impression that this issue was only on the terraform end but was not aware it also extended to the Azure API. I'll sit tight and wait for the changes to be implemented 😃 |
katbyte
added
the
upstream/microsoft
katbyte
removed
the
upstream/microsoft
|
We have updated the SDK so this should be unblocked now 🙂 |
|
Thanks! @katbyte |
``` $ acctests azurerm TestAccAzureRMCognitiveAccount_speechServices === RUN TestAccAzureRMCognitiveAccount_speechServices === PAUSE TestAccAzureRMCognitiveAccount_speechServices === CONT TestAccAzureRMCognitiveAccount_speechServices --- PASS: TestAccAzureRMCognitiveAccount_speechServices (83.54s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 84.821s ```
There was a problem hiding this comment.
LGTM - thanks for this @lqdev! I hope you don't mind but I've pushed a commit adding a test and docs for this new value
tombuildsstuff
dismissed
katbyte’s stale review
dismissing since changes have been pushed
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
When trying to provision a resource of
Speechkind, there are errors. To correct for this, I added kindSpeechServiceswhich should be compatible with the kind being used by Azure currently for that resource.