New Resource: `azurerm_workloads_sap_single_node_virtual_instance` #24331

neil-yechenwei · 2023-12-26T05:44:31Z

Per Tom's suggestion, I split the SAP Virtual Instance per the configuration type.

--- PASS: TestAccWorkloadsSAPSingleNodeVirtualInstance_basic (2243.90s)
--- PASS: TestAccWorkloadsSAPSingleNodeVirtualInstance_requiresImport (2297.98s)
--- PASS: TestAccWorkloadsSAPSingleNodeVirtualInstance_complete (2504.55s)
--- PASS: TestAccWorkloadsSAPSingleNodeVirtualInstance_update (2321.62s)

Note: Before using this resource, it's required to submit the request of registering the Resource Provider with Azure CLI az provider register --namespace "Microsoft.Workloads". The Resource Provider can take a while to register, you can check the status by running az provider show --namespace "Microsoft.Workloads" --query "registrationState". Once this outputs "Registered" the Resource Provider is available for use. I also added this note in the resource doc.

References:
Azure doc
REST API specs

ms-zhenhua

Thanks for this @neil-yechenwei.
I made a first pass through and left some comments that need to be confirmed. Once those are done we can take another look through!

internal/services/network/validate/network_interface_name.go

internal/services/workloads/workloads_sap_deployment_virtual_instance_resource.go

neil-yechenwei · 2024-01-04T08:15:49Z

@ms-zhenhua , thanks for the comments. I updated PR. Please take another look. Thanks.

ms-zhenhua

Hey @neil-yechenwei , thank you for your updates.
I made another pass through and left some comments that need to be confirmed. Once those are done we can take another look through!

internal/services/workloads/workloads_sap_single_node_virtual_instance_resource.go

website/docs/r/workloads_sap_single_node_virtual_instance.html.markdown

…hosconfig

tombuildsstuff · 2024-01-25T16:37:53Z

hey @neil-yechenwei

We’ve made some structural changes to hashicorp/go-azure-sdk which have split the SDK into multiple Go Modules. This means that the SDK which previously existed at github.com/hashicorp/go-azure-sdk now exists at:

github.com/hashicorp/go-azure-sdk/resource-manager - for the Resource Manager SDK.
github.com/hashicorp/go-azure-sdk/sdk - for the base layer.

We’ve updated the Provider to use the new Go Module structure in PR #24636 - as such would you mind rebasing this Pull Request on top of main to remove the merge conflict?

Thanks!

neil-yechenwei · 2024-01-26T12:06:01Z

I updated PR for the SDK change.

catriona-m

Hi @neil-yechenwei I took a look through this and left a couple of comments, but once those are addressed we can take another look at this. Since this is similar to #24384, it seems that some of the comments there will apply on this pr too. Thanks!

catriona-m · 2024-03-05T20:06:52Z

internal/services/workloads/validate/sap_virtual_instance_name.go

+	value := v.(string)
+
+	if matched := regexp.MustCompile(`^[A-Z][A-Z0-9][A-Z0-9]$`).Match([]byte(value)); !matched {
+		errors = append(errors, fmt.Errorf("%q must be an alphabet for the first letter. The second and third letters must be alphanumeric and all alphabets must be uppercase", k))


Suggested change

errors = append(errors, fmt.Errorf("%q must be an alphabet for the first letter. The second and third letters must be alphanumeric and all alphabets must be uppercase", k))

errors = append(errors, fmt.Errorf("%q must have three characters. The first character must be alphabetic. The second and third characters must be alphanumerical. All alphabetic characters should be uppercase.", k))

catriona-m · 2024-03-05T20:32:05Z

internal/services/workloads/workloads_sap_single_node_virtual_instance_resource.go

+						MaxItems: 1,
+						Elem: &pluginsdk.Resource{
+							Schema: map[string]*pluginsdk.Schema{
+								"data_disk_names": {


can we update this to work the same way as data_disk in azurerm_workloads_sap_three_tier_virtual_instance for consistency?

catriona-m · 2024-03-05T21:10:05Z

internal/services/workloads/workloads_sap_single_node_virtual_instance_resource_test.go

+  environment                 = "NonProd"
+  sap_product                 = "S4HANA"
+  app_location                = azurerm_resource_group.app.location
+  managed_resource_group_name = "managedTestRG%d"


should we prefix these with acctest

neil-yechenwei · 2024-03-07T03:33:23Z

@catriona-m , I updated PR. Below is the test result I just know triggered. Please take another look. Thanks.

--- PASS: TestAccWorkloadsSAPSingleNodeVirtualInstance_basic (2218.54s)
--- PASS: TestAccWorkloadsSAPSingleNodeVirtualInstance_requiresImport (2093.39s)
--- PASS: TestAccWorkloadsSAPSingleNodeVirtualInstance_complete (1975.75s)
--- PASS: TestAccWorkloadsSAPSingleNodeVirtualInstance_update (2149.06s)

catriona-m

Thanks for making the additional changes @neil-yechenwei - LGTM 🏅 !

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.93.0" to "3.94.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.94.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.94.0
FEATURES:

* **New Resource**: `azurerm_kubernetes_fleet_update_run` ([#24813](https://github.com/hashicorp/terraform-provider-azurerm/issues/24813))

ENHANCEMENTS:

* dependencies: updating to `v0.20240228.1142829` of `github.com/hashicorp/go-azure-sdk` ([#25081](https://github.com/hashicorp/terraform-provider-azurerm/issues/25081))
* `servicefabric`: updating to use the transport layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#25002](https://github.com/hashicorp/terraform-provider-azurerm/issues/25002))
* `springcloud`: updating to API Version `2024-01-01-preview` ([#24937](https://github.com/hashicorp/terraform-provider-azurerm/issues/24937))
* `securitycenter`: updating to use the transport layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#25081](https://github.com/hashicorp/terraform-provider-azurerm/issues/25081))
* Data Source: `azurerm_storage_table_entities` - support for `select` ([#24987](https://github.com/hashicorp/terraform-provider-azurerm/issues/24987))
* Data Source: `azurerm_netapp_volume` - support for the `smb_access_based_enumeration` and `smb_non_browsable` properties ([#24514](https://github.com/hashicorp/terraform-provider-azurerm/issues/24514))
* `azurerm_cosmosdb_account` - add support for the `minimal_tls_version` property ([#24966](https://github.com/hashicorp/terraform-provider-azurerm/issues/24966))
* `azurerm_federated_identity_credential` - the federated credentials can now be changed without creating a new resource ([#25003](https://github.com/hashicorp/terraform-provider-azurerm/issues/25003))
* `azurerm_kubernetes_cluster` - support for the `current_kubernetes_version` property ([#25079](https://github.com/hashicorp/terraform-provider-azurerm/issues/25079))
* `azurerm_kubernetes_cluster` - private DNS is now allowed for the `web_app_routing` property ([#25038](https://github.com/hashicorp/terraform-provider-azurerm/issues/25038))
* `azurerm_kubernetes_cluster` - migration between different `outbound_type`s is now allowed ([#25021](https://github.com/hashicorp/terraform-provider-azurerm/issues/25021))
* `azurerm_mssql_database` - support for the `recovery_point_id` and `restore_long_term_retention_backup_id` properties ([#24904](https://github.com/hashicorp/terraform-provider-azurerm/issues/24904))
* `azurerm_linux_virtual_machine` - support for the `automatic_upgrade_enabled`, `disk_controller_type`, `os_image_notification`, `treat_failure_as_deployment_failure_enabled`, and `vm_agent_platform_updates_enabled`properties ([#23394](https://github.com/hashicorp/terraform-provider-azurerm/issues/23394))
* `azurerm_nginx_deployment` - support for the `automatic_upgrade_channel` property ([#24867](https://github.com/hashicorp/terraform-provider-azurerm/issues/24867))
* `azurerm_netapp_volume` - support for the `smb_access_based_enumeration` and `smb_non_browsable` properties ([#24514](https://github.com/hashicorp/terraform-provider-azurerm/issues/24514))
* `azurerm_netapp_pool` - support for the `encryption_type` property ([#24993](https://github.com/hashicorp/terraform-provider-azurerm/issues/24993))
* `azurerm_role_definition` - upgrade to the API version `2022-05-01-preview` ([#25008](https://github.com/hashicorp/terraform-provider-azurerm/issues/25008))
* `azurerm_redis_cache` - allow AAD auth for all SKUs ([#25006](https://github.com/hashicorp/terraform-provider-azurerm/issues/25006))
* `azurerm_sql_managed_instance` - support for the `zone_redundant_enabled` property ([#25089](https://github.com/hashicorp/terraform-provider-azurerm/issues/25089))
* `azurerm_spring_cloud_gateway` - support for the `application_performance_monitoring_ids` property ([#24919](https://github.com/hashicorp/terraform-provider-azurerm/issues/24919))
* `azurerm_spring_cloud_configuration_service` - support for the `refresh_interval_in_seconds` property ([#25009](https://github.com/hashicorp/terraform-provider-azurerm/issues/25009))
* `azurerm_synapse_workspace` - support for using the `user_assigned_identity_id` property within the `customer_managed_key` block ([#25027](https://github.com/hashicorp/terraform-provider-azurerm/issues/25027))
* `azurerm_windows_virtual_machine` - support for the `automatic_upgrade_enabled`, `disk_controller_type`, `os_image_notification`, `treat_failure_as_deployment_failure_enabled`, and `vm_agent_platform_updates_enabled`properties ([#23394](https://github.com/hashicorp/terraform-provider-azurerm/issues/23394))

BUG FIXES:

* `azurerm_api_management_notification_recipient_email` - fixing an issue where response pages weren't iterated over correctly ([#25055](https://github.com/hashicorp/terraform-provider-azurerm/issues/25055))
* `azurerm_api_management_notification_recipient_user` - fixing an issue where response pages weren't iterated over correctly ([#25055](https://github.com/hashicorp/terraform-provider-azurerm/issues/25055))
* `azurerm_batch_pool` - fix setting the `extension.settings_json` property ([#24976](https://github.com/hashicorp/terraform-provider-azurerm/issues/24976))
* `azurerm_key_vault_key` - `expiration_date` can be updated if newer date is ahead ([#25000](https://github.com/hashicorp/terraform-provider-azurerm/issues/25000))
* `azurerm_pim_active_role_assignment` - fix an isue where the resource would disappear or fail to import after 45 days ([#24524](https://github.com/hashicorp/terraform-provider-azurerm/issues/24524))
* `azurerm_pim_eligible_role_assignment` - fix an isue where the resource would disappear or fail to import after 45 days ([#24524](https://github.com/hashicorp/terraform-provider-azurerm/issues/24524))
* `azurerm_recovery_services_vault` - validate that `use_system_assigned_identity` and `user_assigned_identity_id` cannot be set at the same time ([#24091](https://github.com/hashicorp/terraform-provider-azurerm/issues/24091))
* `azurerm_recovery_vaults` will now create properly with `SystemAssigned,UserAssigned` identity ([#24978](https://github.com/hashicorp/terraform-provider-azurerm/issues/24978))
* `azurerm_subscription` - fixing an issue where response pages weren't iterated over correctly ([#25055](https://github.com/hashicorp/terraform-provider-azurerm/issues/25055))


</pre> </details> <details> <summary>3.95.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.95.0
FEATURES:

* New Resource: `azurerm_container_app_custom_domain` ([#24421](https://github.com/hashicorp/terraform-provider-azurerm/issues/24421))
* New Resource: `azurerm_data_protection_backup_instance_kubernetes_cluster` ([#24940](https://github.com/hashicorp/terraform-provider-azurerm/issues/24940))
* New Resource: `azurerm_static_web_app` ([#25117](https://github.com/hashicorp/terraform-provider-azurerm/issues/25117))
* New resource: `azurerm_static_web_app_custom_domain` ([#25117](https://github.com/hashicorp/terraform-provider-azurerm/issues/25117))
* New resource: `azurerm_system_center_virtual_machine_manager_availability_set` ([#24975](https://github.com/hashicorp/terraform-provider-azurerm/issues/24975))
* New Resource: `azurerm_workloads_sap_three_tier_virtual_instance` ([#24384](https://github.com/hashicorp/terraform-provider-azurerm/issues/24384))
* New Resource: `azurerm_workloads_sap_single_node_virtual_instance` ([#24331](https://github.com/hashicorp/terraform-provider-azurerm/issues/24331))

ENHANCEMENTS:

* `dependencies`: updating to v0.20240229.1102109 of `github.com/hashicorp/go-azure-sdk` ([#25102](https://github.com/hashicorp/terraform-provider-azurerm/issues/25102))
* `monitor`: updating to use the transport layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` [GH-#25102]
* `network`: updating to API Version `2023-09-01` ([#25095](https://github.com/hashicorp/terraform-provider-azurerm/issues/25095))
* `azurerm_data_factory_integration_runtime_managed` - support for the `credential_name` property ([#25033](https://github.com/hashicorp/terraform-provider-azurerm/issues/25033))
* `azurerm_linux_function_app` - support for the `description` property in the `ip_restriction` block ([#24527](https://github.com/hashicorp/terraform-provider-azurerm/issues/24527))
* `azurerm_linux_function_app` - support for the `ip_restriction_default_action` and `scm_ip_restriction_default_action` properties ([#25131](https://github.com/hashicorp/terraform-provider-azurerm/issues/25131))
* `azurerm_linux_function_app_slot` - support for the `description` property in the `ip_restriction` block ([#24527](https://github.com/hashicorp/terraform-provider-azurerm/issues/24527))
* `azurerm_linux_function_app_slot` - support for the `ip_restriction_default_action` and `scm_ip_restriction_default_action` properties ([#25131](https://github.com/hashicorp/terraform-provider-azurerm/issues/25131))
* `azurerm_linux_web_app` - support for the `description` property in the `ip_restriction` block ([#24527](https://github.com/hashicorp/terraform-provider-azurerm/issues/24527))
* `azurerm_linux_web_app` - support for the `ip_restriction_default_action` and `scm_ip_restriction_default_action` properties ([#25131](https://github.com/hashicorp/terraform-provider-azurerm/issues/25131))
* `azurerm_linux_web_app_slot` - support for the `description` property in the `ip_restriction` block ([#24527](https://github.com/hashicorp/terraform-provider-azurerm/issues/24527))
* `azurerm_linux_web_app_slot` - support for the `ip_restriction_default_action` and `scm_ip_restriction_default_action` properties ([#25131](https://github.com/hashicorp/terraform-provider-azurerm/issues/25131))
* `azurerm_mysql_flexible_server` - setting the `storage.size_gb` property to a smaller value now forces a new resource to be created ([#25074](https://github.com/hashicorp/terraform-provider-azurerm/issues/25074))
* `azurerm_orbital_contact_profile` - changing the `channels` property no longer creates a new resource ([#25129](https://github.com/hashicorp/terraform-provider-azurerm/issues/25129))
* `azurerm_private_dns_resolver_inbound_endpoint` - the `private_ip_address` property is no longer required when `private_ip_allocation_method` is `Dynamic` ([#25035](https://github.com/hashicorp/terraform-provider-azurerm/issues/25035))
* `stream_analytics_output_blob` - support for the `blob_write_mode` property ([#25127](https://github.com/hashicorp/terraform-provider-azurerm/issues/25127))
* `azurerm_windows_function_app` - support for the `description` property in the `ip_restriction` block ([#24527](https://github.com/hashicorp/terraform-provider-azurerm/issues/24527))
* `azurerm_windows_function_app` - support for the `ip_restriction_default_action` and `scm_ip_restriction_default_action` properties ([#25131](https://github.com/hashicorp/terraform-provider-azurerm/issues/25131))
* `azurerm_windows_function_app_slot` - support for the `description` property in the `ip_restriction` block ([#24527](https://github.com/hashicorp/terraform-provider-azurerm/issues/24527))
* `azurerm_windows_function_app_slot` - support for the `ip_restriction_default_action` and `scm_ip_restriction_default_action` properties ([#25131](https://github.com/hashicorp/terraform-provider-azurerm/issues/25131))
* `azurerm_windows_web_app` - support for the `description` property in the `ip_restriction` block ([#24527](https://github.com/hashicorp/terraform-provider-azurerm/issues/24527))
* `azurerm_windows_web_app` - support for the `ip_restriction_default_action` and `scm_ip_restriction_default_action` properties ([#25131](https://github.com/hashicorp/terraform-provider-azurerm/issues/25131))
* `azurerm_windows_web_app_slot` - support for the `description` property in the `ip_restriction` block ([#24527](https://github.com/hashicorp/terraform-provider-azurerm/issues/24527))
* `azurerm_windows_web_app_slot` - support for the `ip_restriction_default_action` and `scm_ip_restriction_default_action` properties ([#25131](https://github.com/hashicorp/terraform-provider-azurerm/issues/25131))

BUG FIXES:

* Data Source: `azurerm_function_app_host_keys` - correctly set `event_grid_extension_key` by searching for the renamed property in the API response ([#25108](https://github.com/hashicorp/terraform-provider-azurerm/issues/25108))
* `azurerm_app_service_public_certificate` - fix issue where certificate information was not being set correctly in the read ([#24943](https://github.com/hashicorp/terraform-provider-azurerm/issues/24943))
* `azurerm_container_registry` - prevent recreation of the resource when the `georeplication.tags` are updated ([#24994](https://github.com/hashicorp/terraform-provider-azurerm/issues/24994))
* `azurerm_firewall_policy_rule_collection_group` - fix issue where the client subscription ID was used to construct the `firewall_policy_id` ([#25145](https://github.com/hashicorp/terraform-provider-azurerm/issues/25145))
* `azurerm_function_app_hybrid_connection` - fix issue where `SendKeyValue` was not populated in the API payload ([#23761](https://github.com/hashicorp/terraform-provider-azurerm/issues/23761))
* `azurerm_orbital_contact_profile` - fix creation of the resource when `event_hub_uri` is not specified ([#25128](https://github.com/hashicorp/terraform-provider-azurerm/issues/25128))
* `azurerm_recovery_services_vault` - prevent a panic when `immutability` is updated ([#25132](https://github.com/hashicorp/terraform-provider-azurerm/issues/25132))
* `azurerm_storage_account` - fix issue where the queue encryption key type was set as the table encryption key type ([#25046](https://github.com/hashicorp/terraform-provider-azurerm/issues/25046))
* `azurerm_web_app_hybrid_connection` - fix issue where `SendKeyValue` was not populated in the API payload ([#23761](https://github.com/hashicorp/terraform-provider-azurerm/issues/23761))
* `azurerm_mssql_database` - fix incorrect error due to typo when using `restore_long_term_retention_backup_id` ([#25180](https://github.com/hashicorp/terraform-provider-azurerm/issues/25180))

DEPRECATIONS:

* Deprecated Resource: `azurerm_static_site` ([#25117](https://github.com/hashicorp/terraform-provider-azurerm/issues/25117))
* Deprecated Resource: `azurerm_static_site_custom_domain` ([#25117](https://github.com/hashicorp/terraform-provider-azurerm/issues/25117))
* `azurerm_kubernetes_fleet_manager` - the `hub_profile` property has been deprecated ([#25010](https://github.com/hashicorp/terraform-provider-azurerm/issues/25010))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/40/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> --------- Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>

github-actions · 2024-04-19T02:07:30Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

New Resource: azurerm_workloads_sap_deployment_virtual_instance

535281f

github-actions bot added documentation dependencies service/storage service/network size/XL labels Dec 26, 2023

update code

de68357

neil-yechenwei marked this pull request as draft December 26, 2023 08:55

neil-yechenwei added 2 commits December 27, 2023 08:05

update code

9348661

update code

db59dae

ms-zhenhua suggested changes Dec 28, 2023

View reviewed changes

github-actions bot added the waiting-response label Dec 28, 2023

update code

731cf81

github-actions bot removed the waiting-response label Jan 2, 2024

neil-yechenwei added 3 commits January 2, 2024 16:45

update code

df444f3

update code

77361a1

update code

e5f3366

neil-yechenwei changed the title ~~New Resource: azurerm_workloads_sap_deployment_virtual_instance~~ New Resource: azurerm_workloads_sap_single_node_virtual_instance Jan 4, 2024

github-actions bot added the waiting-response label Jan 4, 2024

update code

9336a8d

github-actions bot removed the waiting-response label Jan 4, 2024

neil-yechenwei requested a review from ms-zhenhua January 4, 2024 08:15

ms-zhenhua suggested changes Jan 5, 2024

View reviewed changes

github-actions bot added the waiting-response label Jan 5, 2024

update code

73eeb08

github-actions bot added waiting-response and removed waiting-response labels Jan 9, 2024

update code

0171d48

github-actions bot removed the waiting-response label Jan 10, 2024

github-actions bot added the waiting-response label Jan 18, 2024

update code

745aff8

github-actions bot removed the waiting-response label Jan 18, 2024

neil-yechenwei added 2 commits January 22, 2024 20:44

Merge remote-tracking branch 'upstream/main' into 2sapvideploymentwit…

2c6d89d

…hosconfig

update code

aa2224e

update code

02c9744

update code

41c1e89

jackofallops requested a review from tombuildsstuff January 29, 2024 11:10

neil-yechenwei added 2 commits February 2, 2024 10:53

update code

23c6795

update code

1c80ce6

katbyte assigned catriona-m Feb 19, 2024

update code

12a9b2a

catriona-m requested changes Mar 5, 2024

View reviewed changes

neil-yechenwei added 4 commits March 6, 2024 16:05

update code

d5ea0fb

update code

8e99b02

update code

a6bf34b

update code

573373d

github-actions bot added the service/workloads label Mar 7, 2024

neil-yechenwei requested a review from catriona-m March 7, 2024 03:33

Update workloads_sap_single_node_virtual_instance.html.markdown

a3d74f9

catriona-m approved these changes Mar 7, 2024

View reviewed changes

catriona-m merged commit d1fd2d2 into hashicorp:main Mar 7, 2024
33 checks passed

github-actions bot added this to the v3.95.0 milestone Mar 7, 2024

catriona-m added a commit that referenced this pull request Mar 7, 2024

Update CHANGELOG.md #24331

7470510

github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_workloads_sap_single_node_virtual_instance` #24331

New Resource: `azurerm_workloads_sap_single_node_virtual_instance` #24331

neil-yechenwei commented Dec 26, 2023 •

edited

Loading

ms-zhenhua left a comment

neil-yechenwei commented Jan 4, 2024

ms-zhenhua left a comment

tombuildsstuff commented Jan 25, 2024

neil-yechenwei commented Jan 26, 2024

catriona-m left a comment

catriona-m Mar 5, 2024

neil-yechenwei Mar 6, 2024

catriona-m Mar 5, 2024

neil-yechenwei Mar 6, 2024

catriona-m Mar 5, 2024

neil-yechenwei Mar 6, 2024

neil-yechenwei commented Mar 7, 2024

catriona-m left a comment

github-actions bot commented Apr 19, 2024

	errors = append(errors, fmt.Errorf("%q must be an alphabet for the first letter. The second and third letters must be alphanumeric and all alphabets must be uppercase", k))
	errors = append(errors, fmt.Errorf("%q must have three characters. The first character must be alphabetic. The second and third characters must be alphanumerical. All alphabetic characters should be uppercase.", k))

New Resource: azurerm_workloads_sap_single_node_virtual_instance #24331

New Resource: azurerm_workloads_sap_single_node_virtual_instance #24331

Conversation

neil-yechenwei commented Dec 26, 2023 • edited Loading

ms-zhenhua left a comment

Choose a reason for hiding this comment

neil-yechenwei commented Jan 4, 2024

ms-zhenhua left a comment

Choose a reason for hiding this comment

tombuildsstuff commented Jan 25, 2024

neil-yechenwei commented Jan 26, 2024

catriona-m left a comment

Choose a reason for hiding this comment

catriona-m Mar 5, 2024

Choose a reason for hiding this comment

neil-yechenwei Mar 6, 2024

Choose a reason for hiding this comment

catriona-m Mar 5, 2024

Choose a reason for hiding this comment

neil-yechenwei Mar 6, 2024

Choose a reason for hiding this comment

catriona-m Mar 5, 2024

Choose a reason for hiding this comment

neil-yechenwei Mar 6, 2024

Choose a reason for hiding this comment

neil-yechenwei commented Mar 7, 2024

catriona-m left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 19, 2024

New Resource: `azurerm_workloads_sap_single_node_virtual_instance` #24331

New Resource: `azurerm_workloads_sap_single_node_virtual_instance` #24331

neil-yechenwei commented Dec 26, 2023 •

edited

Loading