Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TestCase] Fix TestAccDashboardGrafana_withSku #24128

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Dec 6, 2023

Recently TestAccDashboardGrafana_withSku is failed with below error so that I submitted this PR to fix it.

Error Message returned by API:

performing GrafanaCreate:
unexpected status 400 with error: SkuNotSupported: The Grafana Workspace sku
name 'Essential' is not a supported value. Supported sku values are: Standard

Below is the test result after the fix is applied.
image

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neil-yechenwei this sku was added just 2 weeks ago and is also available in the portal. This could be region specific or there's an issue with the API, can you please find out which is the case?

@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Dec 7, 2023

@stephybun , it's weird. The "essential" value was removed from this commit #24014. I add it back and change the test location. Now test case passed. Thanks.

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔄

@katbyte katbyte merged commit 12e0a2a into hashicorp:main Dec 7, 2023
7 checks passed
@github-actions github-actions bot added this to the v3.84.0 milestone Dec 7, 2023
Copy link

github-actions bot commented May 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants