azurerm_spring_cloud_(customized)_accelerator - state migration to fix the ID casing
#23749
Conversation
…accelerator` - state migration to fix the ID casing
There was a problem hiding this comment.
Thanks for this PR @ms-henglu. Overall this looks good - the schema can be condensed, I left a comment on that. Once that's done this should be good to go though.
And thanks for the review @magodo!
| ForceNew: true, | ||
| MaxItems: 1, | ||
| ConflictsWith: []string{"git_repository.0.ssh_auth"}, |
There was a problem hiding this comment.
The state migration schemas don't require attributes like ForceNew, MaxItems, MinItems, ConflictsWith, Default, ExactlyOneOf, RequiredWith etc. since these aren't needed for deserializing the data. Can you please remove these from the schema?
| ForceNew: true, | ||
| }, | ||
|
|
||
| "spring_cloud_service_id": { | ||
| Type: pluginsdk.TypeString, | ||
| Required: true, | ||
| ForceNew: true, |
There was a problem hiding this comment.
As above ForceNew can be removed here.
|
Hi @stephybun , thanks for the review, I've updated the schema. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR adds state migration for
azurerm_spring_cloud_acceleratorandazurerm_spring_cloud_customized_accelerator, to update the ID segment from/Springto/spring.