TypedSDK - add filtering tag for removed schema items
#23415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
approved these changes
Oct 2, 2023
internal/sdk/resource_encode.go
Outdated
| @@ -51,7 +54,8 @@ func recurse(objType reflect.Type, objVal reflect.Value, fieldName string, debug | |||
| for i := 0; i < objType.NumField(); i++ { | |||
| field := objType.Field(i) | |||
| fieldVal := objVal.Field(i) | |||
| if tfschemaTag, exists := field.Tag.Lookup("tfschema"); exists { | |||
| if tfschemaTag, exists := field.Tag.Lookup("tfschema"); exists && !(strings.HasSuffix(tfschemaTag, ",majorVersionRemoved") && features.FourPointOh()) { | |||
There was a problem hiding this comment.
this should be a contains - and/or we should probably split the tags on ,?
internal/sdk/resource_encode.go
Outdated
| @@ -51,7 +54,8 @@ func recurse(objType reflect.Type, objVal reflect.Value, fieldName string, debug | |||
| for i := 0; i < objType.NumField(); i++ { | |||
| field := objType.Field(i) | |||
| fieldVal := objVal.Field(i) | |||
| if tfschemaTag, exists := field.Tag.Lookup("tfschema"); exists { | |||
| if tfschemaTag, exists := field.Tag.Lookup("tfschema"); exists && !(strings.HasSuffix(tfschemaTag, ",majorVersionRemoved") && features.FourPointOh()) { | |||
| tfschemaTag = strings.TrimSuffix(tfschemaTag, ",majorVersionRemoved") | |||
There was a problem hiding this comment.
perhaps removedInNextMajorVersion would be clearer?
There was a problem hiding this comment.
Actually could we also document this in the README too?
tombuildsstuff
approved these changes
Oct 5, 2023
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several crashes hidden behind the major version feature flag for schema changes and provides a mechanism for future deprecated schema item removal.