Add Support for Icon URL in azurerm_bot_service_azure_bot resource #23114

fdmsantos · 2023-08-29T12:53:16Z

tombuildsstuff

Thanks for this PR - I've taken a look through and left a couple of comments inline, but if we can fix those up then this should otherwise be good to go 👍

Thanks!

internal/services/bot/bot_service_resource_base.go

stephybun

Thanks for this @fdmsantos. Could you also add this to the acceptance test, I think the configuration for the update is an appropriate place for this property.

fdmsantos · 2023-09-05T09:41:03Z

Hi, I only can do this on two weeks. Tks.

…

On Tue, Sep 5, 2023, 10:07 stephybun ***@***.***> wrote: ***@***.**** requested changes on this pull request. Thanks for this @fdmsantos <https://github.com/fdmsantos>. Could you also add this to the acceptance test, I think the configuration for the update <https://github.com/hashicorp/terraform-provider-azurerm/blob/main/internal/services/bot/bot_service_azure_bot_resource_test.go#L158> is an appropriate place for this property. — Reply to this email directly, view it on GitHub <#23114 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGGIXOXCPSBDMWSPP6BZBG3XY3TVBANCNFSM6AAAAAA4C5BUSA> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

stephybun

Thanks @fdmsantos.

The tests are failing because this property has a default value. We need to add that to the schema, then this should be good to go!

internal/services/bot/bot_service_resource_base.go

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>

Co-authored-by: stephybun <steph@hashicorp.com>

stephybun

Thanks for this @fdmsantos! Tests are now passing. I hope you don't mind I rebased your branch to fix a merge conflict so that this can go into the next release. LGTM 👍

…3114 #23098 #23342 #23329 #23251

<Actions> <action id="4a39167e811ac038e4a588362092472c27cfbe9e4929ae61d035f708a093a669"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>"hashicorp/azurerm" updated from "3.74.0" to "3.75.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.75.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.75.0
FEATURES:

* New Resource: `azurerm_application_load_balancer` ([#22517](https://github.com/hashicorp/terraform-provider-azurerm/issues/22517))
* New Resource: `azurerm_resource_management_private_link` ([#23098](https://github.com/hashicorp/terraform-provider-azurerm/issues/23098))

ENHANCEMENTS:

* dependencies: `firewall` migrated to `hashicorp/go-azure-sdk` ([#22863](https://github.com/hashicorp/terraform-provider-azurerm/issues/22863))
* `azurerm_bot_service_azure_bot` - add support for the `icon_url` property ([#23114](https://github.com/hashicorp/terraform-provider-azurerm/issues/23114))
* `azurerm_cognitive_deployment` - `capacity` property is now updateable ([#23251](https://github.com/hashicorp/terraform-provider-azurerm/issues/23251))
* `azurerm_container_group` - added support for `key_vault_user_identity_id` ([#23332](https://github.com/hashicorp/terraform-provider-azurerm/issues/23332))
* `azurerm_data_factory` - added support for the `publish_enabled` property ([#2334](https://github.com/hashicorp/terraform-provider-azurerm/issues/2334))
* `azurerm_firewall_policy_rule_collection_group` - add support for the `description` property ([#23354](https://github.com/hashicorp/terraform-provider-azurerm/issues/23354))
* `azurerm_kubernetes_cluster` - `network_profile.network_policy` can be migrated to `cilium` ([#23342](https://github.com/hashicorp/terraform-provider-azurerm/issues/23342))
* `azurerm_log_analytics_workspace` - add support for the `data_collection_rule_id` property ([#23347](https://github.com/hashicorp/terraform-provider-azurerm/issues/23347))
* `azurerm_mysql_flexible_server` - add support for the `io_scaling_enabled` property ([#23329](https://github.com/hashicorp/terraform-provider-azurerm/issues/23329))

BUG FIXES:

* `azurerm_api_management_api` - fix importing `openapi` format content file issue ([#23348](https://github.com/hashicorp/terraform-provider-azurerm/issues/23348))
* `azurerm_cdn_frontdoor_rule` - allow a `cache_duration` of `00:00:00` ([#23384](https://github.com/hashicorp/terraform-provider-azurerm/issues/23384))
* `azurerm_cosmosdb_cassandra_datacenter` - `sku_name` is now updatable ([#23419](https://github.com/hashicorp/terraform-provider-azurerm/issues/23419))
* `azurerm_key_vault_certificate` - fix a bug that prevented soft-deleted certificates from being recovered ([#23204](https://github.com/hashicorp/terraform-provider-azurerm/issues/23204))
* `azurerm_log_analytics_solution` - fix create and update lifecycle of resource by splitting methods ([#23333](https://github.com/hashicorp/terraform-provider-azurerm/issues/23333))
* `azurerm_management_group_subscription_association` - mark resource as gone correctly if not found when retrieving ([#23335](https://github.com/hashicorp/terraform-provider-azurerm/issues/23335))
* `azurerm_management_lock` - add polling after create and delete to check for RP propagation ([#23345](https://github.com/hashicorp/terraform-provider-azurerm/issues/23345))
* `azurerm_monitor_diagnostic_setting` - added validation to ensure at least one of `category` or `category_group` is supplied ([#23308](https://github.com/hashicorp/terraform-provider-azurerm/issues/23308))
* `azurerm_palo_alto_local_rulestack_prefix_list` - fix rulestack not being committed on delete ([#23362](https://github.com/hashicorp/terraform-provider-azurerm/issues/23362))
* `azurerm_palo_alto_local_rulestack_fqdn_list` - fix rulestack not being committed on delete ([#23362](https://github.com/hashicorp/terraform-provider-azurerm/issues/23362))
* `security_center_subscription_pricing_resource` - disabled extensions logic now works as expected ([#22997](https://github.com/hashicorp/terraform-provider-azurerm/issues/22997))



</pre> </details> <details> <summary>3.76.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.76.0
FEATURES:

* New Resource: `azurerm_security_center_storage_defender` ([#23242](https://github.com/hashicorp/terraform-provider-azurerm/issues/23242))
* New Resource: `azurerm_spring_cloud_application_insights_application_performance_monitoring` ([#23107](https://github.com/hashicorp/terraform-provider-azurerm/issues/23107))

ENHANCEMENTS:

* provider: updating to build using Go `1.21.3` ([#23514](https://github.com/hashicorp/terraform-provider-azurerm/issues/23514))
* provider: the `roll_instances_when_required` provider feature in the `virtual_machine_scale_set` block is now optional ([#22976](https://github.com/hashicorp/terraform-provider-azurerm/issues/22976))
* dependencies: updating to `v0.20231012.1141427` of `github.com/hashicorp/go-azure-sdk` ([#23534](https://github.com/hashicorp/terraform-provider-azurerm/issues/23534))
* Data Source: `azurerm_application_gateway` - support for `backend_http_settings`, `global`, `gateway_ip_configuration` and additional attributes ([#23318](https://github.com/hashicorp/terraform-provider-azurerm/issues/23318))
* Data Source: `azurerm_network_service_tags` - export the `name` attribute ([#23382](https://github.com/hashicorp/terraform-provider-azurerm/issues/23382))
* `azurerm_cosmosdb_postgresql_cluster` - add support for `sql_version` of `16` and `citus_version` of `12.1` ([#23476](https://github.com/hashicorp/terraform-provider-azurerm/issues/23476))
* `azurerm_palo_alto_local_rulestack` - correctly normalize the `location` property ([#23483](https://github.com/hashicorp/terraform-provider-azurerm/issues/23483))
* `azurerm_static_site` - add support for `app_settings` ([#23421](https://github.com/hashicorp/terraform-provider-azurerm/issues/23421))

BUG FIXES:

* `azurerm_automation_schedule` - fix a bug when updating `start_time` ([#23494](https://github.com/hashicorp/terraform-provider-azurerm/issues/23494))
* `azurerm_eventhub` - remove ForceNew and check `partition_count` is not decreased ([#23499](https://github.com/hashicorp/terraform-provider-azurerm/issues/23499))
* `azurerm_managed_lustre_file_system` - update validation for `storage_capacity_in_tb` according to `sku_name` in use ([#23428](https://github.com/hashicorp/terraform-provider-azurerm/issues/23428))
* `azurerm_virtual_machine` - fix a crash when the API response for the `os_profile` block contains nil properties ([#23535](https://github.com/hashicorp/terraform-provider-azurerm/issues/23535))


</pre> </details> </details> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> --------- Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com> Co-authored-by: Damien Duportal <damien.duportal@gmail.com>

github-actions · 2024-05-13T02:11:24Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added service/bots size/XS labels Aug 29, 2023

tombuildsstuff suggested changes Sep 5, 2023

View reviewed changes

internal/services/bot/bot_service_resource_base.go Show resolved Hide resolved

internal/services/bot/bot_service_resource_base.go Outdated Show resolved Hide resolved

tombuildsstuff added the waiting-response label Sep 5, 2023

github-actions bot added documentation and removed waiting-response labels Sep 5, 2023

fdmsantos requested a review from tombuildsstuff September 5, 2023 07:15

stephybun requested changes Sep 5, 2023

View reviewed changes

github-actions bot added the waiting-response label Sep 5, 2023

github-actions bot removed the waiting-response label Sep 5, 2023

tombuildsstuff added the waiting-response label Sep 11, 2023

github-actions bot removed the waiting-response label Sep 18, 2023

stephybun requested changes Sep 20, 2023

View reviewed changes

internal/services/bot/bot_service_resource_base.go Outdated Show resolved Hide resolved

stephybun added the enhancement label Sep 20, 2023

fdmsantos and others added 7 commits September 22, 2023 08:32

Add Support for Icon URL in azurerm_bot_service_azure_bot resource

d748173

Apply suggestions from code review

353d842

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>

Add icon_url attribute to documentation

db6726d

update property description

280a731

Add icon_url attribute to acceptance test

f05f337

Add default value to icon_url parameter

48da630

Co-authored-by: stephybun <steph@hashicorp.com>

rebase and terrafmt

977a238

github-actions bot added size/S and removed size/XS labels Sep 22, 2023

switch to pointer.From in read

baa89ac

stephybun approved these changes Sep 22, 2023

View reviewed changes

stephybun merged commit 085cc1d into hashicorp:main Sep 22, 2023
23 checks passed

github-actions bot added this to the v3.75.0 milestone Sep 22, 2023

fdmsantos deleted the add-support-for-icon-on-bot-service branch September 22, 2023 10:16

stephybun added a commit that referenced this pull request Sep 28, 2023

Update for #23345 #23204 #23344 #23308 #23333 #23332 #23335 #23354 #2…

ff98670

…3114 #23098 #23342 #23329 #23251

github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Support for Icon URL in azurerm_bot_service_azure_bot resource #23114

Add Support for Icon URL in azurerm_bot_service_azure_bot resource #23114

fdmsantos commented Aug 29, 2023

tombuildsstuff left a comment

stephybun left a comment

fdmsantos commented Sep 5, 2023 via email

stephybun left a comment

stephybun left a comment •

edited

Loading

github-actions bot commented May 13, 2024

Add Support for Icon URL in azurerm_bot_service_azure_bot resource #23114

Add Support for Icon URL in azurerm_bot_service_azure_bot resource #23114

Conversation

fdmsantos commented Aug 29, 2023

tombuildsstuff left a comment

Choose a reason for hiding this comment

stephybun left a comment

Choose a reason for hiding this comment

fdmsantos commented Sep 5, 2023 via email

stephybun left a comment

Choose a reason for hiding this comment

stephybun left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented May 13, 2024

stephybun left a comment •

edited

Loading