Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delegation support for Subnet #2042

Merged
merged 28 commits into from
Jan 8, 2019
Merged

Add delegation support for Subnet #2042

merged 28 commits into from
Jan 8, 2019

Commits on Oct 8, 2018

  1. ✨ (Subnet.) Add delegations for subnet. 

    Add delegation for subnet to support ACI VNet.
    @metacpp
    metacpp committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    913460a View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2018

  1. 🐛 (Delegation of Subnet.) Resolve flatten method issue. 

    Fix the type issue for `service_delegation`.
    @metacpp
    metacpp committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    8f9b6ef View commit details
    Browse the repository at this point in the history

  2. ♻️ (Delegation of Subnet.) Add delegation for subnet. 

    Add delegation for subnet to integrate with ACI.
    @metacpp
    metacpp committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    2150745 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2018

  1. Merge changes from master branch.

    @metacpp
    metacpp committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    0f2d267 View commit details
    Browse the repository at this point in the history

  2. Resolve issues in PR and network package upgrade.

    @metacpp
    metacpp committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    cf7d75b View commit details
    Browse the repository at this point in the history

  3. Fix: linting errors in test files.

    @metacpp
    metacpp committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    1ed0eff View commit details
    Browse the repository at this point in the history

  4. Undo unnecessary changes in network related tests.

    @metacpp
    metacpp committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    09178ac View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2018

  1. Ensuring the NSG ID is always set 

    Tests pass
```
$ acctests azurerm TestAccAzureRMSubnet_removeNetworkSecurityGroup
=== RUN   TestAccAzureRMSubnet_removeNetworkSecurityGroup
--- PASS: TestAccAzureRMSubnet_removeNetworkSecurityGroup (140.01s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	141.927s
```
    @tombuildsstuff
    tombuildsstuff committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    5ff5d4b View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2018

  1. Merge branch 'master' into subnet_delegation

    @metacpp
    metacpp authored Dec 4, 2018
    Configuration menu
    Copy the full SHA
    c3f3747 View commit details
    Browse the repository at this point in the history

  2. Add back ICMP and clean up code for AG and NSG.

    @metacpp
    metacpp committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    c9cbb1e View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2018

  1. git merge master -S

    @katbyte
    katbyte committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    743c3ef View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2018

  1. Resolve naming and documentation issue for delegation in subnet.

    @metacpp
    metacpp committed Dec 24, 2018
    Configuration menu
    Copy the full SHA
    88d3063 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. Update website/docs/r/subnet.html.markdown 

    Co-Authored-By: metacpp <1684739+metacpp@users.noreply.github.com>
    @tombuildsstuff @metacpp
    tombuildsstuff and metacpp authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    915e2e6 View commit details
    Browse the repository at this point in the history

  2. Update website/docs/r/subnet.html.markdown 

    Co-Authored-By: metacpp <1684739+metacpp@users.noreply.github.com>
    @tombuildsstuff @metacpp
    tombuildsstuff and metacpp authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    c5a1b3f View commit details
    Browse the repository at this point in the history

  3. Update website/docs/r/subnet.html.markdown 

    Co-Authored-By: metacpp <1684739+metacpp@users.noreply.github.com>
    @tombuildsstuff @metacpp
    tombuildsstuff and metacpp authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    3c1c99f View commit details
    Browse the repository at this point in the history

  4. Update azurerm/resource_arm_subnet.go 

    Co-Authored-By: metacpp <1684739+metacpp@users.noreply.github.com>
    @tombuildsstuff @metacpp
    tombuildsstuff and metacpp authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    fa068a4 View commit details
    Browse the repository at this point in the history

  5. Update website/docs/r/subnet.html.markdown 

    Co-Authored-By: metacpp <1684739+metacpp@users.noreply.github.com>
    @tombuildsstuff @metacpp
    tombuildsstuff and metacpp authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    caefa61 View commit details
    Browse the repository at this point in the history

  6. Update website/docs/r/subnet.html.markdown 

    Co-Authored-By: metacpp <1684739+metacpp@users.noreply.github.com>
    @tombuildsstuff @metacpp
    tombuildsstuff and metacpp authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    5c720cf View commit details
    Browse the repository at this point in the history

  7. Update azurerm/resource_arm_subnet_test.go 

    Co-Authored-By: metacpp <1684739+metacpp@users.noreply.github.com>
    @tombuildsstuff @metacpp
    tombuildsstuff and metacpp authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    95bb542 View commit details
    Browse the repository at this point in the history

  8. Update azurerm/resource_arm_subnet.go 

    Co-Authored-By: metacpp <1684739+metacpp@users.noreply.github.com>
    @tombuildsstuff @metacpp
    tombuildsstuff and metacpp authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    4a72e06 View commit details
    Browse the repository at this point in the history

  9. Update azurerm/resource_arm_subnet.go 

    Co-Authored-By: metacpp <1684739+metacpp@users.noreply.github.com>
    @tombuildsstuff @metacpp
    tombuildsstuff and metacpp authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    047a946 View commit details
    Browse the repository at this point in the history

  10. Update azurerm/resource_arm_subnet.go 

    Co-Authored-By: metacpp <1684739+metacpp@users.noreply.github.com>
    @tombuildsstuff @metacpp
    tombuildsstuff and metacpp authored Jan 3, 2019
    Configuration menu
    Copy the full SHA
    d15de3e View commit details
    Browse the repository at this point in the history

  11. update the sample code in documentation.

    @metacpp
    metacpp committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    e299a69 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2019

  1. Add flatten function for delegation and resolve issues in PR.

    @metacpp
    metacpp committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    1e80242 View commit details
    Browse the repository at this point in the history

  2. Fix the goimport issue.

    @metacpp
    metacpp committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    cd06da2 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2019

  1. Update azurerm/resource_arm_subnet.go 

    Co-Authored-By: metacpp <1684739+metacpp@users.noreply.github.com>
    @tombuildsstuff @metacpp
    tombuildsstuff and metacpp authored Jan 5, 2019
    Configuration menu
    Copy the full SHA
    981a6b8 View commit details
    Browse the repository at this point in the history

  2. Add nil check for flatten function

    @metacpp
    metacpp committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    3eccbeb View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2019

  1. Fix: alignment issue and nil check consistency.

    @metacpp
    metacpp committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    70c4108 View commit details
    Browse the repository at this point in the history