-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support a couple of new sentinel data connectors #18795
Conversation
sentinel_data_connector_office_irm
sentinel_data_connector_office_irm
, sentinel_data_connector_office_power_bi
sentinel_data_connector_office_irm
, sentinel_data_connector_office_power_bi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @magodo, thanks for this PR.
This looks fine, but seeing as these would need to be rewritten as typed resources at some point for Pandora and these resources are practically identical (aside from the Kind
/Type
) this would lend itself well to being rewritten now and defining a "base resource" which the different connectors pass their Kind
to. costmanagement
has an example of what I mean.
Thanks!
|
||
type SentinelDataConnectorDynamics365Resource struct{} | ||
|
||
func TestAccAzureRMSentinelDataConnectorDynamics365_basic(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we remove AzureRM
from all the test names
func TestAccAzureRMSentinelDataConnectorDynamics365_basic(t *testing.T) { | |
func TestAccSentinelDataConnectorDynamics365_basic(t *testing.T) { |
@stephybun Thank you for the comment, I'll do the migration and split each resource into their own PR. I'll close this PR for now. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Implements a couple of sentinel new data connectors:
sentinel_data_connector_office_irm
sentinel_data_connector_office_power_bi
sentinel_data_connector_office_365_project
sentinel_data_connector_dynamics_365
sentinel_data_connector_iot
azurerm_sentinel_data_connector_microsoft_threat_protection
Relating to #18195.
Test