Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport AzureStack route_table PR review comments #1790

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Aug 18, 2018

@katbyte katbyte added this to the 1.14.0 milestone Aug 18, 2018
@katbyte katbyte changed the title backport azure stack route_table PR review comments backport AzureStack route_table PR review comments Aug 18, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 552d613 into master Aug 21, 2018
@tombuildsstuff tombuildsstuff deleted the azstack-route_table branch August 21, 2018 07:07
torresdal added a commit to torresdal/terraform-provider-azurerm that referenced this pull request Aug 23, 2018
* master: (95 commits)
  Some more AzureStack changes for route table resource and datasource (hashicorp#1807)
  backport AzureStack route resource PR comments (hashicorp#1810)
  Updating to include hashicorp#1799
  Bug Fix of azurerm_virtual_machine.storage_os_disk.image_uri (hashicorp#1799)
  Updating to include hashicorp#1693
  IoT Hub add endpoints and routes (hashicorp#1693)
  Updating to include hashicorp#1789
  Added support for EventHub compatible EndPoints and Paths (hashicorp#1789)
  Updating to include hashicorp#1798
  Remove client side validation for azure network plugin (hashicorp#1798)
  backport azure stack route_table PR review comments (hashicorp#1790)
  Update CHAGELOG.md to include hashicorp#1795
  Fix: Corrected regexp for eventhub name
  reset verb
  fix some pointer dereferences
  Fix indentation on application_gateway.html.markdown (hashicorp#1780)
  folded subscription and [az]schema packages into azure
  consolidate CaseDifference Supression functions
  Cleanup after v1.13.0 release
  v1.13.0
  ...
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants