-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add storage account config to function apps #16684
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr @Benedikt-Fuchs-Crayon - i think we'lll need to update the docs with the new properties?
9f6117b
to
e80fcd8
Compare
e80fcd8
to
991ac52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Benedikt-Fuchs-Crayon - looks like we have some test failures to fix thou:
…ame in withStorageAccount and withStorageAccountUpdate methods.
@katbyte thank you for testing it, I sadly didn't manage to setup the acceptance tests myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Benedikt-Fuchs-Crayon
Thanks for the changes, there's just a couple test config changes needed and I think this is good to go.
Thanks!
internal/services/appservice/windows_function_app_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/appservice/windows_function_app_resource_test.go
Outdated
Show resolved
Hide resolved
…windows_web_app_resource_test.go
thank you for the feedback, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Benedikt-Fuchs-Crayon - still seeing some test failures related to this pr:
Hi @Benedikt-Fuchs-Crayon - To resolve the conflicts and extend the feature to slots I've pulled your changes onto a new branch/PR (I was unable to safely push to your fork as the PR originated from your Thanks again for the contribution, and apologies for the delays in getting back to this! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
adds support for storage_account blocks in azurerm__function_app as described in #6790
also fixing a small copy paste mistake, where a error message falsely claims the wrong os