Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_cdn_endpoint -origin.0.http/https_ports are now set as the default values of 80/443 #16143

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

christurk
Copy link
Contributor

When httpPort/httpsPort are set to 80/443 (the default), Azure sets these values to null. As a result, the provider attempts to re-create the cdn endpoint to update the origin ports from 0/0 -> 80/443 even though they are already set that way.

This PR makes it so that null-valued ports are correctly interpreted as 80/443 instead of 0/0.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title nil-valued http/https ports should be 80/443 not 0 azurerm_cdn_endpoint -origin.0.http/https_ports are now set as 80/443 Apr 21, 2022
@mbfrahry mbfrahry changed the title azurerm_cdn_endpoint -origin.0.http/https_ports are now set as 80/443 azurerm_cdn_endpoint -origin.0.http/https_ports are now set as the default values of 80/443 Apr 21, 2022
@mbfrahry mbfrahry merged commit aaa81f5 into hashicorp:main Apr 21, 2022
@github-actions github-actions bot added this to the v3.3.0 milestone Apr 21, 2022
mbfrahry added a commit that referenced this pull request Apr 21, 2022
@github-actions
Copy link

This functionality has been released in v3.3.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants