kubernetes_cluster_resource support network_profile.ip_versions

[qiqingzhang]

create a public pull request for kubernetes_cluster_resource support network_profile.ip_families

Link to #15708

[stephybun]

Thanks for this PR @heiazuo, this is off to a good start. Aside from the comments left in-line I also have two additional suggestions:

1. We should create an additional test that tests dual-stack networking with the value ["IPv4", "IPv6"]
2. In the create method could we add a check that throws an error if a user tries to specify ["IPv6"], the validation for the property allows it, but it isn't valid for the API.

Once the above is addressed we can take another look through this.

[qiqingzhang]

Thanks @stephybun, thanks for your suggestion, I made the changes as suggested

[stephybun]

Thanks for renaming the property and adding the test for dual-stack networking @heiazuo, I still have a question and suggestion regarding the check on the value.

[stephybun]

Like so

Suggested change

	func expandIPVersions(input []interface{}) *[]containerservice.IPFamily {
	if len(input) == 0 {
	return nil
	}
	ipf := make([]containerservice.IPFamily, 0)
	for _, data := range input {
	ipf = append(ipf, containerservice.IPFamily(data.(string)))
	}
	return &ipf
	}
	func expandIPVersions(input []interface{}) (*[]containerservice.IPFamily, error) {
	if len(input) == 0 {
	return nil, nil
	}
	ipf := make([]containerservice.IPFamily, 0)
	for _, data := range input {
	ipf = append(ipf, containerservice.IPFamily(data.(string)))
	}
	if len(ipf) == 1 && ipf[0] == containerservice.IPFamilyIPv6 {
	return nil, fmt.Errorf("`ip_versions` must be `IPv4` or `IPv4` and `IPv6`. `IPv6` alone is not supported")
	}
	return &ipf, nil
	}

[stephybun]

Suggested change

	ipVersions := config["ip_versions"].([]interface{})
	networkProfile := containerservice.NetworkProfile{
	NetworkPlugin: containerservice.NetworkPlugin(networkPlugin),
	NetworkMode: containerservice.NetworkMode(networkMode),
	NetworkPolicy: containerservice.NetworkPolicy(networkPolicy),
	LoadBalancerSku: containerservice.LoadBalancerSku(loadBalancerSku),
	OutboundType: containerservice.OutboundType(outboundType),
	IPFamilies: expandIPVersions(ipVersions),
	ipVersions, err := expandIPVersions(config["ip_versions"].([]interface{}))
	if err != nil {
	return nil, err
	}
	networkProfile := containerservice.NetworkProfile{
	NetworkPlugin: containerservice.NetworkPlugin(networkPlugin),
	NetworkMode: containerservice.NetworkMode(networkMode),
	NetworkPolicy: containerservice.NetworkPolicy(networkPolicy),
	LoadBalancerSku: containerservice.LoadBalancerSku(loadBalancerSku),
	OutboundType: containerservice.OutboundType(outboundType),
	IPFamilies: ipVersions,
	}

[stephybun]

Thanks @heiazuo, LGTM 🥟

[github-actions]

This functionality has been released in v3.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.