sqlvm upgrade include new features #15945

tikicoder · 2022-03-22T20:53:00Z

This builds off the PR of #15835
This adds the newer functionality from the new version of the API

…review

katbyte

Thanks for the pr @tikicoder - i've left some minor comments about schema inline. in addtion to this we'll need to add these to a test. once thats done this should be good to merge! thanks

internal/services/mssql/helper/sql_virtual_machine_storage_settings.go

internal/services/mssql/mssql_virtual_machine_resource.go

…tings.go Co-authored-by: kt <kt@katbyte.me>

Co-authored-by: kt <kt@katbyte.me>

tikicoder · 2022-05-12T20:51:13Z

@katbyte I have accepted all the changes.

internal/services/mssql/mssql_virtual_machine_resource.go

myc2h6o · 2022-05-13T03:21:45Z

Hi @tikicoder thanks for the pr! I found there seems to be a missing update of the expandSqlVirtualMachineTempDbSettings and flattenSqlVirtualMachineTempDbSettings functions for the updated SQLTempDBStorageSettingSchema. Would you mind updating them? And it would be great if you could add a test around these new properties. Thanks!

pulling in main

tikicoder · 2022-05-13T04:17:30Z

@myc2h6o can you verify the updates and I think I have updated the test to at least a couple of the new settings.

myc2h6o · 2022-05-13T07:42:44Z

internal/services/mssql/mssql_virtual_machine_resource.go

 	return &sqlvirtualmachine.SQLTempDbSettings{
-		Luns:            expandSqlVirtualMachineStorageSettingsLuns(dataStorageSettings["luns"].([]interface{})),
-		DefaultFilePath: utils.String(dataStorageSettings["default_file_path"].(string)),
+		luns:              	expandSqlVirtualMachineStorageSettingsLuns(tempDbSettings["luns"].([]interface{})),
+		data_file_count:   	utils.Int32(int32(tempDbSettings.Get("data_file_count").(int))),
+		data_file_size_mb: 	utils.Int32(int32(tempDbSettings.Get("data_file_size_mb").(int))),
+		data_file_growth_in_mb: utils.Int32(int32(tempDbSettings.Get("data_file_growth_in_mb").(int))),
+		default_file_path: 	utils.String(tempDbSettings["default_file_path"].(string)),
+		log_file_size_mb: 	utils.Int32(int32(tempDbSettings.Get("log_file_size_mb").(int))),
+		log_file_growth_mb: 	utils.Int32(int32(tempDbSettings.Get("log_file_growth_mb").(int)))


field name of SQLTempDbSettings needs to be corrected, e.g. data_file_count ->DataFileCount

Ok this should be resolved

myc2h6o · 2022-05-13T07:45:59Z

internal/services/mssql/mssql_virtual_machine_resource.go

@@ -882,12 +894,32 @@ func flattenSqlVirtualMachineTempDbSettings(input *sqlvirtualmachine.SQLTempDbSe
 	}
 	attrs := make(map[string]interface{})

-	if input.Luns != nil {
-		attrs["luns"] = *input.Luns
+	if input.luns != nil {


Same here, field name of SQLTempDbSettings needs to be corrected. e.g. in Terraform the attribute name is luns and in the sdk struct its Luns

Ok this should be resolved

added new test

removed extra space

tikicoder · 2022-06-10T21:23:01Z

@myc2h6o @katbyte It's ready for the workflow. I think I got the issues resolved.

tikicoder · 2022-06-17T16:22:21Z

@katbyte can you approve running the workflows. This is my first contribution to the repo.

tikicoder · 2022-06-29T17:43:47Z

@myc2h6o @katbyte Can one of you trigger the rest of the approval steps. This is my first time contributing so I am unable to.

myc2h6o · 2022-06-30T08:55:57Z

Hi @tikicoder thanks for the update. the workflow seems to fail due to build issue.
This resource has been switched to use the new sdk github.com/hashicorp/go-azure-sdk/resource-manager/sqlvirtualmachine/2022-02-01/sqlvirtualmachines thus the build fails, would you mind merge the latest main branch? You may need to update some code to use the new sdk as well.

tikicoder · 2022-06-30T16:45:29Z

@myc2h6o Thanks I will check it out.

tikicoder · 2022-07-23T00:10:51Z

Hi @tikicoder thanks for the update. the workflow seems to fail due to build issue. This resource has been switched to use the new sdk github.com/hashicorp/go-azure-sdk/resource-manager/sqlvirtualmachine/2022-02-01/sqlvirtualmachines thus the build fails, would you mind merge the latest main branch? You may need to update some code to use the new sdk as well.

I have pulled in the latest changes.

myc2h6o · 2022-08-03T15:12:28Z

@tikicoder thanks for the update and sorry for the late response. There are some build errors due to the sdk migration. I've opened tikicoder#3 to resolve them. Could you take a look there?
And there is a duplicate test config storageConfiguration in mssql_virtual_machine_resource_test.go, would you mind updating its name and put it into the test step? I think you can take TestAccMsSqlVirtualMachine_autoPatching as a reference

mbfrahry · 2022-10-24T22:24:54Z

Hey @tikicoder, thanks for getting the bulk of this work done. I went ahead and fixed it up in #18923 and that'll go out in the next release!

tikicoder · 2022-10-24T22:57:13Z

@mbfrahry Thanks for taking it home, work has me swamped.

Thanks again.

github-actions · 2022-11-24T02:19:30Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

myc2h6o and others added 2 commits March 15, 2022 18:08

dependencies: Upgrade sqlvirtualmachine API version to 2021-11-01-p…

7d10f36

…review

sql updates

e838ed9

github-actions bot added dependencies documentation service/mssql Microsoft SQL Server size/XL labels Mar 22, 2022

tikicoder changed the title ~~sqlvm upgrade~~ sqlvm upgrade include new features Mar 22, 2022

tikicoder mentioned this pull request Mar 22, 2022

Support expanded tempdb settings in azurerm_mssql_virtual_machine #15707

Open

Merge branch 'main' into tiki_sqlvm_upgrade

0f2da95

github-actions bot added size/M and removed dependencies size/XL labels May 6, 2022

katbyte requested changes May 12, 2022

View reviewed changes

tikicoder and others added 5 commits May 12, 2022 13:41

Update internal/services/mssql/helper/sql_virtual_machine_storage_set…

5940a09

…tings.go Co-authored-by: kt <kt@katbyte.me>

Update internal/services/mssql/helper/sql_virtual_machine_storage_set…

730ae2f

…tings.go Co-authored-by: kt <kt@katbyte.me>

Update internal/services/mssql/helper/sql_virtual_machine_storage_set…

64b24ba

…tings.go Co-authored-by: kt <kt@katbyte.me>

Update internal/services/mssql/helper/sql_virtual_machine_storage_set…

eca962d

…tings.go Co-authored-by: kt <kt@katbyte.me>

Update internal/services/mssql/mssql_virtual_machine_resource.go

916fee7

Co-authored-by: kt <kt@katbyte.me>

myc2h6o reviewed May 13, 2022

View reviewed changes

internal/services/mssql/mssql_virtual_machine_resource.go Show resolved Hide resolved

tikicoder added 4 commits May 12, 2022 20:49

Update mssql_virtual_machine.html.markdown

e673a25

Update mssql_virtual_machine_resource.go

764987d

Merge pull request #1 from tikicoder/main

5520ecb

pulling in main

Update mssql_virtual_machine_resource_test.go

8f6b48d

tikicoder requested a review from katbyte May 13, 2022 04:22

myc2h6o reviewed May 13, 2022

View reviewed changes

Update mssql_virtual_machine_resource.go

67fd530

tikicoder and others added 9 commits June 6, 2022 19:16

Update mssql_virtual_machine_resource_test.go

4e967bf

added new test

Update mssql_virtual_machine_resource.go

4ed6162

removed extra space

gofmt -s updates

8bf6a2f

updates based on feedback

89d2631

reverted change pending feedback

5d3d88e

Update mssql_virtual_machine_resource.go

13c8454

Update mssql_virtual_machine_resource.go

8ef3957

ran fmter

42e7810

Merge branch 'hashicorp:main' into tiki_sqlvm_upgrade

6397155

tikicoder added 2 commits June 14, 2022 10:36

Merge branch 'hashicorp:main' into tiki_sqlvm_upgrade

9bdef9c

Merge branch 'hashicorp:main' into tiki_sqlvm_upgrade

87d5c95

upstream pull

43afd2e

tikicoder added 2 commits June 30, 2022 09:45

Merge branch 'hashicorp:main' into tiki_sqlvm_upgrade

a877a5f

Merge branch 'hashicorp:main' into tiki_sqlvm_upgrade

c7ac9e7

katbyte added the waiting-response label Aug 18, 2022

katbyte assigned mbfrahry Oct 17, 2022

mbfrahry mentioned this pull request Oct 22, 2022

azurerm_mssql_virtual_machine - add support for assessment #18923

Merged

mbfrahry closed this Oct 24, 2022

github-actions bot removed the waiting-response label Oct 24, 2022

github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sqlvm upgrade include new features #15945

sqlvm upgrade include new features #15945

tikicoder commented Mar 22, 2022

katbyte left a comment

tikicoder commented May 12, 2022

myc2h6o commented May 13, 2022 •

edited

Loading

tikicoder commented May 13, 2022

myc2h6o May 13, 2022

tikicoder May 13, 2022

myc2h6o May 13, 2022 •

edited

Loading

tikicoder May 13, 2022

tikicoder commented Jun 10, 2022

tikicoder commented Jun 17, 2022

tikicoder commented Jun 29, 2022

myc2h6o commented Jun 30, 2022

tikicoder commented Jun 30, 2022

tikicoder commented Jul 23, 2022

myc2h6o commented Aug 3, 2022

mbfrahry commented Oct 24, 2022

tikicoder commented Oct 24, 2022

github-actions bot commented Nov 24, 2022

sqlvm upgrade include new features #15945

sqlvm upgrade include new features #15945

Conversation

tikicoder commented Mar 22, 2022

katbyte left a comment

Choose a reason for hiding this comment

tikicoder commented May 12, 2022

myc2h6o commented May 13, 2022 • edited Loading

tikicoder commented May 13, 2022

myc2h6o May 13, 2022

Choose a reason for hiding this comment

tikicoder May 13, 2022

Choose a reason for hiding this comment

myc2h6o May 13, 2022 • edited Loading

Choose a reason for hiding this comment

tikicoder May 13, 2022

Choose a reason for hiding this comment

tikicoder commented Jun 10, 2022

tikicoder commented Jun 17, 2022

tikicoder commented Jun 29, 2022

myc2h6o commented Jun 30, 2022

tikicoder commented Jun 30, 2022

tikicoder commented Jul 23, 2022

myc2h6o commented Aug 3, 2022

mbfrahry commented Oct 24, 2022

tikicoder commented Oct 24, 2022

github-actions bot commented Nov 24, 2022

myc2h6o commented May 13, 2022 •

edited

Loading

myc2h6o May 13, 2022 •

edited

Loading