Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_log_analytics_workspace_table -- added to allow retention_in_days to be configured for a given table. Fix for issue 10573 #15462

Closed
wants to merge 4 commits into from

Conversation

markrzasa
Copy link
Contributor

This pull request attempts to resolve the following issues:

Please let me know if you would prefer separate pull requests for each issue.

@markrzasa
Copy link
Contributor Author

markrzasa commented Feb 27, 2022

Hi Everyone,

I realize there are a lot of pull requests to go through, but if anyone has a couple minutes, would you mind looking over the azurerm_log_analytics_workspace_table resource in this PR. Just want to make sure I'm on the right track for configuring individual tables included in log analytics workspaces.

Thanls,
Mark

@markrzasa markrzasa changed the title Add azurerm_log_analytics_workspace_table to allow retention_in_days to be configured for a given table. Fix for issue 10573 azurerm_log_analytics_workspace_table -- added to allow retention_in_days to be configured for a given table. Fix for issue 10573 Mar 6, 2022
@stephybun
Copy link
Member

Hi @markrzasa,

Thanks for this PR and apologies for the delayed review here.

I’ve taken a look through and noticed that the new resource azurerm_log_analytics_workspace_table isn't able to create nor delete a Log Analytics Workspace Table with the API version that we're using, in order to support this in Terraform we’ll need to approach this with a few extra steps. This is supported in the latest version of the API however unfortunately that’s not supported in the Azure SDK for Go and so we’ll need to generate an SDK for this. This SDK will support Create, Update and Deleting Workspace Tables - as such we’ll be able to manage this as a resource in Terraform, however this generation will need to be done by someone at HashiCorp.

Could you go ahead and move your bug fix out into a separate PR and I will open a PR in the coming days with the generated SDK.

Thanks!

@markrzasa
Copy link
Contributor Author

Absolutely. No problem. Should I abandon this pull request or use it to integrate with the new version of the Azure SDK?

@stephybun
Copy link
Member

It will probably be easiest to abandon this PR. Thanks again!

@markrzasa markrzasa closed this Mar 15, 2022
@markrzasa
Copy link
Contributor Author

Will revisit this once the Azure SDK for Go is updated.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants