Support for managed identity in azurerm_automation_account resource
#15072
Conversation
damienpontifex
changed the title
azurerm_automation_account resource
There was a problem hiding this comment.
Hi @damienpontifex - thanks for the PR. Running the tests for this and it appears we have a number of test failures:
------- Stdout: -------
=== RUN TestAccAutomationAccount_complete
=== PAUSE TestAccAutomationAccount_complete
=== CONT TestAccAutomationAccount_complete
testcase.go:110: Step 1/2 error: Error running pre-apply refresh: exit status 1
Error: Insufficient identity blocks
on terraform_plugin_test.tf line 11, in resource "azurerm_automation_account" "test":
11: resource "azurerm_automation_account" "test" {
At least 1 "identity" blocks are required.
--- FAIL: TestAccAutomationAccount_complete (18.42s)
FAIL
- Adopt 2020-01-13-preview API version of automation that has identity within it - Update enum names that were changed with the API version update - Follow identity block pattern from other resources within this repo - Update documentation to include identity block capability
| @@ -71,10 +73,104 @@ func resourceAutomationAccount() *pluginsdk.Resource { | |||
| Type: pluginsdk.TypeString, | |||
| Computed: true, | |||
| }, | |||
|
|
|||
| "identity": { | |||
There was a problem hiding this comment.
hey @damienpontifex
Thanks for this PR - apologies for the delayed review on this one - I'm currently working through the provider to make the identity blocks consistent as a part of #15187, as such I hope you don't mind but I'm going to push a couple of commits to update this to use the Common Schema for Identity so that this is consistent with that.
Thanks!
There was a problem hiding this comment.
I would never mind @tombuildsstuff :) In this together to make things awesome, so I appreciate your input to make this consistent and shippable.
Thanks for the commits and ongoing work here 👏🏻
There was a problem hiding this comment.
hey @damienpontifex
Thanks again for this PR - apologies for the delayed review.
As mentioned earlier we're currently working through usages of the identity block to make these behaviourally consistent for 3.0 which is being tracked in #15187.
I've taken a look through and left one minor comment in addition to the identity changes, as such I hope you don't mind but I'm going to push a commit to fix that so that we can get this merged 👍
Thanks!
tombuildsstuff
dismissed
katbyte’s stale review
dismissing since changes have been pushed
…identity Turns out you can't create an Identity with Type: None but you can update it that way
|
This functionality has been released in v2.96.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
within it
Relates to #11503